-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pki: generating CSR through API #5783
Conversation
On a second thought, we probably should offer the option of which private key to use: root, intermediate, or dedicated. |
Ohh I really like where this is going! Will take a look after the weekend :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this is going! I don't have any strong suggestions right now. I think I wouldn't do much differently.
Co-authored-by: Matt Holt <[email protected]>
ce51659
to
a9933aa
Compare
I still have not addressed this because I don't know the best design for the payload to accommodate this. Ideas are welcome. |
Maybe it could be a query string parameter? |
@mohammed90 Just cleaning up our milestones... do you have any interest (and time, I know you are busy) to finish this up soon? If not, I wonder if closing this would relieve some pressure? And we can always revisit again later if you want to? |
I don't see it important to finish. It's best we focus our energy elsewhere for now. We've figured the approach if it becomes an interest in the future. |
Some platforms request CSR as part of their process of generating mutually trusted credentials. This PR is to try out the idea of letting Caddy generate the CSRs as a feature of the
pki
app. The ergonomics are to be discussed.Test run:
P.S.: The PR is currently a draft until the code is cleaned up and tests are added