Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddyfile: Correctly close the heredoc when the closing marker appears immediately #6062

Merged
merged 1 commit into from
Jan 25, 2024
Merged

caddyfile: Correctly close the heredoc when the closing marker appears immediately #6062

merged 1 commit into from
Jan 25, 2024

Conversation

bbaa-bbaa
Copy link
Contributor

Correctly close the heredoc when the closing marker appears immediately

francislavoie
francislavoie approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense 👍

@francislavoie francislavoie added the bug 🐞 Something isn't working label Jan 25, 2024
@francislavoie francislavoie added this to the v2.8.0 milestone Jan 25, 2024
@francislavoie francislavoie enabled auto-merge (squash) January 25, 2024 14:47
@francislavoie francislavoie merged commit c369df5 into caddyserver:master Jan 25, 2024
25 checks passed
@bbaa-bbaa bbaa-bbaa deleted the fix-1 branch February 3, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammed90 mohammed90 mohammed90 left review comments

@francislavoie francislavoie francislavoie approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bbaa-bbaa @francislavoie @mohammed90