Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade CEL to v0.20.1 #6158

Closed
wants to merge 1 commit into from
Closed

chore: Upgrade CEL to v0.20.1 #6158

wants to merge 1 commit into from

Conversation

francislavoie
Copy link
Member

Closes #6157

/cc @TristonianJones I took a crack at it, I think I have it right, but I'd appreciate your review to make sure I didn't do anything stupid. Tests pass 🤷‍♂️

@francislavoie francislavoie added the upstream ⬆️ Relates to some dependency of this project label Mar 8, 2024
@francislavoie francislavoie added this to the v2.8.0 milestone Mar 8, 2024
@francislavoie francislavoie requested a review from mholt March 8, 2024 15:37
modules/caddyhttp/celmatcher.go Show resolved Hide resolved
modules/caddyhttp/celmatcher.go Show resolved Hide resolved
modules/caddyhttp/celmatcher.go Show resolved Hide resolved
@mholt
Copy link
Member

mholt commented Mar 14, 2024

Thanks @francislavoie for spearheading this, and @TristonianJones for the helpful expert feedback! I've applied your feedback in #6161 and, Francis, if you're OK with it I will probably merge that and credit you in the commit, since it had a bit of a head start on the refinements.

But it builds on this work by you both, so thank you!

@mholt mholt closed this Mar 14, 2024
@mholt mholt deleted the upgrade-cel branch March 14, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream ⬆️ Relates to some dependency of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade CEL to v0.20.1 (latest)
3 participants