Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'color' is not a good name for black and white, rename it to BiColor/BWColor ? #136

Open
caemor opened this issue Dec 7, 2022 · 2 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@caemor
Copy link
Owner

caemor commented Dec 7, 2022

See @peckpeck's todo from #132

/// Only for the Black/White-Displays
// TODO : 'color' is not a good name for black and white, rename it to BiColor/BWColor ?
#[derive(Clone, Copy, PartialEq, Eq, Debug)]
pub enum Color {
    /// Black color
    Black,
    /// White color
    White,
}

Peckpecks BWColor might make the most sense for me in describing an enum with black and white, but I'm open to alternatives.

@mangelajo
Copy link
Contributor

Would it be possible to simply use BinaryColor from embedded graphics?

I guess it'a not, additional traits added/etc?

@peckpeck
Copy link
Contributor

peckpeck commented Dec 8, 2022

BinaryColor is On or Off, no easy to guess which is black, which is white

@caemor caemor added help wanted Extra attention is needed question Further information is requested labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants