-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to eslint and prettier #99
Comments
I don't have hard feelings regarding this. But if you feel in the mood of working on it, go for it 👍 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@lipis, do you have a Prettier template ready? This lib could need your help. 🙂 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Let's do that!
I'm not agree with the rules, that standard js dictates, but this is another story. The reason why I suggesting this is because eslint + prettier will produce match more better dev experience. Standardjs has a slogan 'No decisions to make', but that is really not true.
If you look at standard docs or the code of logdown you will see eslint comments everywhere. So we are know exactly what decision was made and we are depending on that decision. According to this the
standard
lib has no sense. There is no encapsulation and moreover configs can not be completely avoided (e.g. ignore config), so in the end resultstandard
is half-hearted solution (at least in the modern world). Better to use eslint directly (we can set up exactly the same rules). It will provide better IDE integration, because everyone has eslint extension installed. Another one good thing is that we will be able to remove/* eslint-env jest */
comments and use eslint overrides instead.Additionally we can add precommit hooks, that will ensure, that we are commiting linted and pushing tested code.
The text was updated successfully, but these errors were encountered: