Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to eslint and prettier #99

Open
SleepWalker opened this issue Oct 12, 2017 · 5 comments
Open

Switch to eslint and prettier #99

SleepWalker opened this issue Oct 12, 2017 · 5 comments
Labels

Comments

@SleepWalker
Copy link
Collaborator

Let's do that!

I'm not agree with the rules, that standard js dictates, but this is another story. The reason why I suggesting this is because eslint + prettier will produce match more better dev experience. Standardjs has a slogan 'No decisions to make', but that is really not true.

If you look at standard docs or the code of logdown you will see eslint comments everywhere. So we are know exactly what decision was made and we are depending on that decision. According to this the standard lib has no sense. There is no encapsulation and moreover configs can not be completely avoided (e.g. ignore config), so in the end result standard is half-hearted solution (at least in the modern world). Better to use eslint directly (we can set up exactly the same rules). It will provide better IDE integration, because everyone has eslint extension installed. Another one good thing is that we will be able to remove /* eslint-env jest */ comments and use eslint overrides instead.

Additionally we can add precommit hooks, that will ensure, that we are commiting linted and pushing tested code.

@caiogondim
Copy link
Owner

I don't have hard feelings regarding this.
But I would rather work on smashing bugs, making the lib faster, making it more reliable :)

But if you feel in the mood of working on it, go for it 👍
I vote for merging.

@stale
Copy link

stale bot commented Nov 12, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 12, 2017
@bennycode
Copy link
Collaborator

@lipis, do you have a Prettier template ready? This lib could need your help. 🙂

@lipis
Copy link
Contributor

lipis commented Dec 26, 2017

@bennyn here you go: #104 :)

@stale
Copy link

stale bot commented Jan 25, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants