Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-0001: Rewrite Cake CLI #2333

Closed
patriksvensson opened this issue Oct 18, 2018 · 14 comments · Fixed by #2334
Closed

RFC-0001: Rewrite Cake CLI #2333

patriksvensson opened this issue Oct 18, 2018 · 14 comments · Fixed by #2334
Assignees
Milestone

Comments

@patriksvensson
Copy link
Member

As described in RFC-0001.

@patriksvensson patriksvensson self-assigned this Oct 18, 2018
@adamhathcock
Copy link
Contributor

I was coming back in to look at something like this. I think this is a good idea. I just want it to still play nice with the dotnet global tool installation as well!

@patriksvensson
Copy link
Member Author

@adamhathcock The goal is that we should be 100% backwards compatible after this change, but have some more fine grained commands (and a cleaner architecture and code base in the Cake CLI).

Is there anything in particular that you're thinking about? All feedback is very appreciated here 😄

@adamhathcock
Copy link
Contributor

The usage of --target=something isn't discoverable and I was wanting to change that. I'm glad you already on top it

@patriksvensson
Copy link
Member Author

patriksvensson commented Oct 30, 2018

Ah, you mean adding --target as a first class citizen of the CLI?

@adamhathcock
Copy link
Contributor

I just realized the mistake in my thinking. target is just a suggested argument to the script. I guess understanding that was my fault but I wasn't sure there was a better way to present that in the CLI help

@gep13
Copy link
Member

gep13 commented Oct 30, 2018

@patriksvensson said...
as a first class citizen of the CLI?

Actually, I hadn't realised that it wasn't. Yes, I would say that it should be. Is there a reason that it isn't?

@gep13
Copy link
Member

gep13 commented Oct 30, 2018

Since --exclusive is there, and it requires a named target to be exclusive on, I would say that --target should be there as well.

@adamhathcock
Copy link
Contributor

maybe there should be --task to specify a task directly instead of having to manually have an argument for the Default task? I guess that's a separate issue and change.

@patriksvensson
Copy link
Member Author

@gep13 said...
Actually, I hadn't realised that it wasn't. Yes, I would say that it should be. Is there a reason that it isn't?

Well, right now we require the user to get the target from the provided arguments and pass it to RunTarget. I think this only makes sense if we remove RunTarget and does this implicitly for the user, but that is a completely different issue (and probably a RFC).

@devlead
Copy link
Member

devlead commented Oct 30, 2018

I think this only makes sense if we remove RunTarget and does this implicitly for the user, but that is a completely different issue (and probably a RFC).

If doing that we should have a --no-target option too, to opt out of task implicit RunTarget. And target should almost be an configuration so it/default can be supplied via environment/argument/config without needing to parse script first.

@SUMUKHA-PK
Copy link

Hello all, I found this as an interesting exercise to do in my freetime (and I have loads of it currently), although I'd be needing help in familiarising myself with the codebase. Please do provide me some pointers to start myself with.
Thanks.

@patriksvensson
Copy link
Member Author

@SUMUKHA-PK I'm already working on a PR for this here: #2334

@SUMUKHA-PK
Copy link

Thanks for letting me know @patriksvensson

@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants