Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers for adding multiple strings to ProcessArgumentBuilder #2870

Closed
gitfool opened this issue Oct 3, 2020 · 3 comments · Fixed by #2871
Closed

Add helpers for adding multiple strings to ProcessArgumentBuilder #2870

gitfool opened this issue Oct 3, 2020 · 3 comments · Fixed by #2871
Milestone

Comments

@gitfool
Copy link
Contributor

gitfool commented Oct 3, 2020

ProcessArgumentBuilder has a FromString helper and implicit conversion operator that makes it trivial to work with a single string but has no helpers for another common case of adding multiple strings, assuming they should be handled homogeneously - either all naked or all quoted. Also, the single string case could use a helper that quotes its argument too, so overall I propose the following additional helpers:

  • FromStringQuoted
  • FromStrings
  • FromStringsQuoted
  • ToProcessArguments (extension)
@gitfool
Copy link
Contributor Author

gitfool commented Oct 20, 2020

Example usage in Cake.Dungeon/scripts/tasks.cake where Build.ToolSettings.UnitTestRunSettings is a simple string[].

@pascalberger could this issue be added to the v1.0.0 milestone?

@pascalberger
Copy link
Member

Added to 1.0.0 milestone since we have an open PR

@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants