Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overload for DotNetCoreRun #2913

Closed
patriksvensson opened this issue Oct 21, 2020 · 2 comments
Closed

Add overload for DotNetCoreRun #2913

patriksvensson opened this issue Oct 21, 2020 · 2 comments
Labels
Improvement
Milestone
v1.0.0

Comments

@patriksvensson
Copy link
Member

Right now, you can't pass DotnetCoreRunSettings to DotNetCoreRun(..) without also passing a ProcessArgumentBuilder. It should not be required to pass that parameter to provide settings for the run command.

See documentation for more context: https://cakebuild.net/api/Cake.Common.Tools.DotNetCore/DotNetCoreAliases/0B9C4933
@Marusyk Marusyk mentioned this issue Oct 25, 2020
Merged
@devlead devlead added this to the v1.0.0 milestone Oct 28, 2020
@devlead
Copy link
Member

devlead commented Oct 28, 2020

Fixed by #2915

@devlead devlead closed this as completed Oct 28, 2020
@devlead devlead mentioned this issue Nov 5, 2020
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@patriksvensson @devlead @cake-build-bot