Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed UI change: trailing week #16

Open
jbclements opened this issue Oct 1, 2015 · 5 comments
Open

proposed UI change: trailing week #16

jbclements opened this issue Oct 1, 2015 · 5 comments

Comments

@jbclements
Copy link
Member

Currently, the weekly UI displays fixed weeks; I believe it would be more intuitive if instead it showed the last seven days. The UI would then have to change to add "week back" and "week forward" buttons, and would probably need to show the dates currently in view.

@bommysk
Copy link
Contributor

bommysk commented Oct 1, 2015

Ah okay, may take a bit of work, will think it through.

@bommysk
Copy link
Contributor

bommysk commented Oct 2, 2015

Would the week back and week forward buttons not show fixed weeks as well? Little confused. I will have more time to work on this tomorrow!

Also this is just my opinion but isn't the drop down for the week more intuitive? I just like how the three drop downs look like a calendar that you can change up. It may even be quicker for the user, for instance if the someone wanted to go from week 1 to week 4 with the week forward button it would be three clicks while with the drop down it would be one click. That is something to consider. Just my opinion, if you still want the UI changed, and if we are not running behind schedule then I can still do it, I don't foresee it being too difficult.

@jbclements
Copy link
Member Author

sorry, let me try to explain better. Suppose today is october 1st (as in fact it is). Then I would expect that when I first go to the temperature page for (say) the bedroom, I would see the dates September 25th on the left through October 1st on the right. If I click the left button, I would expect to see data for the 18th through the 24th of september. Does this make more sense?

@bommysk
Copy link
Contributor

bommysk commented Oct 2, 2015

Ah I see that is much better, I will get it done tomorrow.

@bommysk
Copy link
Contributor

bommysk commented Oct 3, 2015

doing a good bit of code refactoring, not difficult just time consuming, can you remind what the timeline for this is again, it needs to be done by Sunday? I should have it done in 2 hours or so if everything goes okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants