Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statement of python 3.12 support #211

Closed
phildong opened this issue Mar 23, 2024 · 9 comments
Closed

statement of python 3.12 support #211

phildong opened this issue Mar 23, 2024 · 9 comments
Labels

Comments

@phildong
Copy link

phildong commented Mar 23, 2024

When trying to reproduce the tests locally, I hit TypeError: type 'typing.TypeVar' is not an acceptable base type, which seem to be a known issue with python 3.12: python/typing_extensions#243

I notice some python version spec in .github/workflows and .python-version but they're easy to miss (maybe it's just me). So maybe consider either investigate python 3.12 support or stating supported version (<=3.11) more explicitly in README?

@caleb531
Copy link
Owner

caleb531 commented Mar 23, 2024

@phildong After some troubleshooting, it appears we have this fixed on the develop branch, but not on main. if you would like to unblock yourself, please use the develop branch until I publish a release to PyPI (planning to do that soon, if not today).

My apologies for the inconvenience.

cc @eliotwrobson

@eliotwrobson
Copy link
Collaborator

@caleb531 as part of this support, we should add classifiers that denote which versions of Python have been supported by the package: https://pypi.org/classifiers/

Then, we can have the badge on the readme reflect this.

@caleb531
Copy link
Owner

@eliotwrobson It looks like we just recently added said classifiers via c8b1148. So I think we're covered there.

With that, I have a draft of the release notes all ready. @eliotwrobson if you could please review and give a quick sign-off on releasing, I can publish a new minor release with these fixes (and the Aho-Corasick functionality) today.

@eliotwrobson
Copy link
Collaborator

@caleb531 sure! Are these stored as a draft on the GitHub release notes?

@caleb531
Copy link
Owner

@eliotwrobson Yes, that's where I have been trying to keep drafts of the release notes going forward.

@eliotwrobson
Copy link
Collaborator

@caleb531 The release notes look good! I say go ahead 🚀

@caleb531
Copy link
Owner

caleb531 commented Mar 23, 2024

Okay, Automata v8.3.0 is published, fixing Python 3.12 support and adding a few other features/fixes:
https://github.com/caleb531/automata/releases/tag/v8.3.0
https://pypi.org/project/automata-lib/

@phildong You should be able to run tests now off the latest main branch. Just remember to git pull and re-run pip install -r requirements.txt.

Once you confirm this is working successfully for you, I'll close this issue.

@caleb531
Copy link
Owner

@phildong Can you please confirm if you are able to run the tests now under Python 3.12 (after following my steps above)?

@phildong
Copy link
Author

Hey @caleb531 thanks for making this happen! I can confirm all tests work with python 3.12 on my side now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants