-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statement of python 3.12 support #211
Comments
@phildong After some troubleshooting, it appears we have this fixed on the My apologies for the inconvenience. |
@caleb531 as part of this support, we should add classifiers that denote which versions of Python have been supported by the package: https://pypi.org/classifiers/ Then, we can have the badge on the readme reflect this. |
@eliotwrobson It looks like we just recently added said classifiers via c8b1148. So I think we're covered there. With that, I have a draft of the release notes all ready. @eliotwrobson if you could please review and give a quick sign-off on releasing, I can publish a new minor release with these fixes (and the Aho-Corasick functionality) today. |
@caleb531 sure! Are these stored as a draft on the GitHub release notes? |
@eliotwrobson Yes, that's where I have been trying to keep drafts of the release notes going forward. |
@caleb531 The release notes look good! I say go ahead 🚀 |
Okay, Automata v8.3.0 is published, fixing Python 3.12 support and adding a few other features/fixes: @phildong You should be able to run tests now off the latest Once you confirm this is working successfully for you, I'll close this issue. |
@phildong Can you please confirm if you are able to run the tests now under Python 3.12 (after following my steps above)? |
Hey @caleb531 thanks for making this happen! I can confirm all tests work with python 3.12 on my side now. |
When trying to reproduce the tests locally, I hit
TypeError: type 'typing.TypeVar' is not an acceptable base type
, which seem to be a known issue with python 3.12: python/typing_extensions#243I notice some python version spec in
.github/workflows
and.python-version
but they're easy to miss (maybe it's just me). So maybe consider either investigate python 3.12 support or stating supported version (<=3.11) more explicitly in README?The text was updated successfully, but these errors were encountered: