Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose 'raw' as an argument? #173

Open
Yaoyx opened this issue Aug 10, 2023 · 2 comments
Open

Expose 'raw' as an argument? #173

Yaoyx opened this issue Aug 10, 2023 · 2 comments

Comments

@Yaoyx
Copy link

Yaoyx commented Aug 10, 2023

dataset = dataset.map(self.generate_parser(raw=True))

It currently returns index format for dna sequence as default. Should this be exposed in case hdf5 file has index format, which seems to be the default (

seq_1hot = dna_1hot_index(seq_dna) # more efficient, but fighting inertia
)

This would, for example, make the explore_model.ipynb data loading consistent with the input shape and format required for a model prediction.

@davek44
Copy link
Contributor

davek44 commented Aug 13, 2023

I won't have time to look into this for awhile. It sounds like you understand what ought to happen, so feel free to submit a pull request.

@Yaoyx Yaoyx mentioned this issue Aug 16, 2023
4 tasks
@Yaoyx
Copy link
Author

Yaoyx commented Aug 16, 2023

I won't have time to look into this for awhile. It sounds like you understand what ought to happen, so feel free to submit a pull request.

Sounds good. I just submitted a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants