Improve Overall Theme Handling

[alitaheri]

After the huge changes made in #2585 it was decided to break the PR into fractions.

The roadmap for changing themes:

• rename rawTheme to baseTheme Theme manager improvements #2635
• Improve theme-manager Theme manager improvements #2635
• Improve the theme wrappers
• Write convenient update stopper to address Only re-render when you need to (Potentially huge perf boost) #1176
• The items in Leftovers from #2585 #2624
• Memoization of style objects
• migrate the components

[oliviertassinari]

Correct me if I'm wrong, but I think that we can add the PureRenderMixin to all of our component as soons as they use the muiTheme HOC 💥

[alitaheri]

@oliviertassinari We should move away from using mixins. Why do you think we should use PureRenderMixin? can't we just use a method to check for changes?

[oliviertassinari]

@oliviertassinari We should move away from using mixins

Yeah, yeah, that's an implementation detail 😬.
My point is, I think that it's going to be really easy to fix #1176.

[newoga]

I agree we should not use mixins but if @oliviertassinari is right, nothing is stopping us from implementing the pure rendering as another HOC like this. 😄

[alitaheri]

@oliviertassinari I definitely agree with This 👍 👍 Also we won't have to check for context since muiThemeable does it ( I guess this is what you meant 😁 ).

@newoga I totally agree. I'm gonna add this before migrating the components.

Thanks a lot for the feedbacks 👍 👍

[oliviertassinari]

we won't have to check for context since muiThemeable does it

Well, I have been giving a lot of thought to this issue.
The main point is that we need to have an immutable context variable muiTheme.
The improve theme-manager will merge values, so people will have to use it to change their muiTheme.
That's going to be far easier for people to have an immutable muiTheme context.

Then, I would refer to #1176 (comment).

[alitaheri]

@oliviertassinari Yeah muiTheme should definitely be marked immutable. We better not use any library. We just document the behavior and say: if you want to change the theme you have to make another call to getMuiTheme with whatever property you want to override theme you like before passing it down. And if you want to change theme for a subtree simply wrap the subtree around a MuiThemeProvider. It's rather easy, don't you think?

[oliviertassinari]

It's rather easy, don't you think?

I completly agree

[alitaheri]

@oliviertassinari Alright. I'm gonna do some research and create a proposal PR with a utility function. 😁 Thanks

[newoga]

@subjectix Didn't get a chance to say thanks for splitting up the work into multiple PRs! So far it's been a lot easier to review. Thanks!

[alitaheri]

@newoga Yeah I was kinda getting a head ache myself 😅 😅

[nathanmarks]

Closing this in favour of all the other related issues :)