Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove cycles #2378

Merged
merged 8 commits into from
Dec 8, 2020
Merged

fix: remove cycles #2378

merged 8 commits into from
Dec 8, 2020

Conversation

unikvozm
Copy link
Contributor

@unikvozm unikvozm commented Nov 23, 2020 •
edited
Loading

Summary

#2336, #2233, #1867

Test plan

@callstack-bot
Copy link

callstack-bot commented Nov 23, 2020 •
edited
Loading

Hey @unikvozm, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@Trancever
Copy link
Contributor

@unikvozm Unfortunately, this breaks the documentation :/ We can't really remove the annotations

@unikvozm
Copy link
Contributor Author

@unikvozm Unfortunately, this breaks the documentation :/ We can't really remove the annotations

fixed

@Trancever
Copy link
Contributor

@unikvozm Hey! In the index.tsx file in the example app we have the following line: YellowBox.ignoreWarnings(['Require cycle:']);. Could you remove it? I think it is not needed anymore since the warnings are gone 👍 Once it's done I will merge the PR

@Trancever
Copy link
Contributor

Thanks!

@Trancever Trancever merged commit cbaf577 into master Dec 8, 2020
@Trancever Trancever deleted the fix/no-cycle branch December 8, 2020 10:52
This was referenced Dec 8, 2020
Closed
Closed
@jaaywags
Copy link

Hi, it looks like this made it in release 4.5.0? I just upgraded to it but I am still receiving the error :(
image
image

@jaaywags jaaywags mentioned this pull request Dec 16, 2020
Closed
@maltoze maltoze mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trancever Trancever Trancever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@unikvozm @callstack-bot @Trancever @jaaywags