Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use text color for Checkbox.Item label #2429

Merged
merged 3 commits into from
Dec 17, 2020
Merged

fix: Use text color for Checkbox.Item label #2429

merged 3 commits into from
Dec 17, 2020

Conversation

kamui545
Copy link
Contributor

I noticed there is an inconsistency between the RadioButton.Item and Checkbox.Item components.
Radio is using colors.text for its label, however, checkbox is using colors.primary.

This PR attempts to fix that by also using colors.text for the Checkbox.Item component.

Snacks from the doc for quick preview of the issue:

@callstack-bot
Copy link

callstack-bot commented Dec 14, 2020

Hey @kamui545, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

Copy link
Contributor

@Trancever Trancever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please make sure tests and lint are passing if possible 🙏 Once it's done we will merge the PR.

@kamui545 kamui545 changed the title Use text color for Checkbox.Item label fix: Use text color for Checkbox.Item label Dec 16, 2020
@kamui545
Copy link
Contributor Author

@Trancever Done : )

@Trancever Trancever merged commit f9aee91 into callstack:master Dec 17, 2020
@Trancever
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants