feat: set default cursor for TouchableRipple to 'pointer' #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here |
Trancever
reviewed
Jan 22, 2021
| @@ -253,6 +254,7 @@ TouchableRipple.supported = true; | |||
| const styles = StyleSheet.create({ | |||
| touchable: { | |||
| position: 'relative', | |||
| ...(Platform.OS === 'web' && { cursor: 'pointer' }), | |||
There was a problem hiding this comment.
Do we really need this conditional? What's gonna happen if we pass cursor: 'pointer' in RN?
Trancever
approved these changes
Jan 22, 2021
This was referenced Mar 13, 2021
|
Ironically, the one place I noticed this goes to 'pointer' from 'default' is in DataTable.Cell, where most of my data is just text (except a couple IconButtons) and they all have pointers making them look clickable so now I need to pass in cursor: default 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While I was working on client's app code I've come to a realisation that in every place where Paper's
<TouchableRipple />component was used we needed to pass additional style to ensure pointer cursor on the web. After some digging I've found that it's caused because TouchabeRipple is using<TouchableWithoutFeedback />under the hood and based on this: necolas/react-native-web#1847 (comment) that's exactly what's causing react-native-web to NOT "inject"cursor: 'pointer'style on the web.Test plan
In the example app:
on mobile device/simulator everything should work exactly the same as before this change.
on the web
<TouchableRipple />component should havepointercursor