Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: example app tweaks #2721

Merged
merged 8 commits into from
May 27, 2021
Merged

fix: example app tweaks #2721

merged 8 commits into from
May 27, 2021

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented May 12, 2021 •
edited
Loading

Summary

  • reload the app when RTL toggle switched
  • correct example list paddings
  • create ScreenWrapper with safe area
  • use DrawerContentScrollView

Test plan

@callstack-bot
Copy link

callstack-bot commented May 12, 2021 •
edited
Loading

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak marked this pull request as ready for review May 13, 2021 14:24
ice-chillios
ice-chillios approved these changes May 23, 2021
View reviewed changes
Copy link

@ice-chillios ice-chillios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Nice refactor here

@lukewalczak lukewalczak merged commit c642587 into main May 27, 2021
@lukewalczak lukewalczak deleted the fix/app-tweaks branch May 27, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice-chillios ice-chillios ice-chillios approved these changes

@brunohkbx brunohkbx brunohkbx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukewalczak @callstack-bot @brunohkbx @ice-chillios