fix: correct Button elevation #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #2736? cc @lukewalczak |
|
@tasugi could you please provide the snack to the issue which you're solving, where we can observe the bug? |
|
@lukewalczak Sure! I created a snack. https://snack.expo.io/@tasugi/reactnativepaper-pr2735 If you press the button, you can change the mode of it |
lukewalczak
reviewed
May 27, 2021
Use useEffect Co-authored-by: Luke Walczak <[email protected]>
|
@lukewalczak Thank you for suggestions! |
lukewalczak
reviewed
May 27, 2021
|
Fixed an issue that caused the test to fail. |
|
Thanks @tasugi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It has a bug that Button elevation is still zero after mode is changed to
containedfrom other modes.This PR fixes this.
Test plan
contained.containedmode dynamically(e.g. on button press).