Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): add importantForAccessibility in Modal component #2743

Merged
merged 1 commit into from
May 27, 2021

Conversation

brunohkbx
Copy link
Collaborator

Summary

It wasn't being possible to focus on the content under the dialog.

Before After
before after

Test plan

  1. Open the dialog example
  2. Focus on the dialog content using TalkBack

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @brunohkbx!

@lukewalczak lukewalczak merged commit 70bb52b into main May 27, 2021
@lukewalczak lukewalczak deleted the fix/modal-accessibility branch May 27, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants