fix: using theme in Text's components, renaming typescales to fonts #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
force-pushed
the
fix/correct-typescales
branch
from
fd56c3d
to
c939b5c
Compare
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here |
1 similar comment
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
force-pushed
the
fix/correct-typescales
branch
from
baa2538
to
ef5f142
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
added
Appbar
Dialog
Drawer
FAB
Menu
BottomNavigation
Chip
SegmenetedButtons
labels
lukewalczak
force-pushed
the
fix/correct-typescales
branch
from
ef5f142
to
1687e63
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
|
@lukewalczak When are you planning on merging this? |
|
The mobile version of example app from this branch is ready! You can see it here |
|
LGTM. Please merge |
lukewalczak
force-pushed
the
fix/correct-typescales
branch
from
5f4802f
to
1cfd414
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3305 #3369
PR:
typescaletofontsto avoid confusion between them in version 5Textcomponent to acceptfontFamilyTextwith variant, such as:AppbarContentBottomNavigationChipDialogTitleDrawerCollapsedItemFABGroupMenuItemSegmentedButtonItemTextInputTest plan
configureFonts