fix: android elevation issue #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
DimitarNestorov
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In regards to #3467 this seems to fix the issue.
This seems to be an issue on how
renderToHardwareTextureAndroidhandles off-screen components. For some reason, upon navigation, we try to animate all previously visited screens - even the ones not visible at all. That's where the bug happens. We can mitigate it by allowingrenderToHardwareTextureAndroidonly on the focused screen.Not sure if that's the proper way to address the issue so I'll be grateful for any feedback.
Test plan
The owner provided a repo to reproduce the issue: https://github.com/iM-GeeKy/shadows-bug