Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the loading prop to IconButton and updated react native #4201

Conversation

kaushik1094
Copy link
Contributor

@kaushik1094 kaushik1094 commented Nov 24, 2023

Motivation

Adding loading prop to IconButton component

Related issue

#4200

Nov-24-2023 15-19-42

Test plan

All unit tests have passed.
Added the IconButton example for loading
Running the example for IconButton

@callstack-bot
Copy link

callstack-bot commented Nov 24, 2023

Hey @kaushik1094, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak lukewalczak linked an issue Nov 28, 2023 that may be closed by this pull request
@lukewalczak lukewalczak added this to the 5.12.0 milestone Nov 28, 2023
@lukewalczak lukewalczak force-pushed the feat/Adding-loading-prop-to-ICON-button branch from 38a3740 to 278da72 Compare January 8, 2024 13:26
@lukewalczak lukewalczak force-pushed the feat/Adding-loading-prop-to-ICON-button branch from 278da72 to ee9aca8 Compare January 8, 2024 13:31
@lukewalczak lukewalczak merged commit 80edc1a into callstack:main Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IconButton loading prop
3 participants