-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove deprecated use of defaultProps #4385
Conversation
Hey @timbocole, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
LGTM, This will be on version 5.12.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solves bug report #4402 for me. Thank you!
Hi @gedu @sethimcclaine any Idea when is 5.12.4 scheduled for? |
Hi all!! Thanks for the work!. So I shall wait until the next release ? and ignore the error message? Thanks!!!!! |
Hey, we are trying to upgrade paper to support almost latest RN version, and after that we will submit it, I hope as soon as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for removing default props.
on RN 0.74.2 I get a warning with this problem. |
Is there any update with this PR? |
When it will be released to main? |
The main maintainer of the library has been really busy these past days. I would like him to perform a final check on all the open PRs that will be merged for Milestone 5.12.4. Hope it will be soon |
merge pleeease |
merge please 🙏 |
Following the tradition of asking for a merge, could you please merge that one? 😆 |
How do I follow this pull request to know when it gets merged? |
Why don't merge this PR? Many of people is waiting to be approved. |
Merge the change finally. This isn't a breaking change or something, there are no reasons to keep this for months. |
No way. The code broke. Is this because of that change? |
This broke the update - https://github.com/callstack/react-native-paper/pull/4422/files Also, there is a PR that will fix it - #4466 Mostly will be available in the next release |
I was about to say, not sure how this PR could be at fault! 😂 - Thanks @raajnadar for the update/fix. |
This issue also affects version 4. What would be the best way to take this fix to that version as well? |
Motivation
This PR prevents the error log warning the "defaultProps" will be removed (visible in RN0.74.0)
Related issue
Addresses #4382
Test plan
Ensure that use of the
TextInputIcon
does not produce the error (included in linked issue) when run using RN0.74.0