fix(text-input-affix): fix right TextInput.Affix alignment with onPress #4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @seb-zabielski, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
@seb-zabielski Cool thanks for the PR, can you provide some video showing the fix? |
|
@gedu I have updated the description and added the recordings there |
gedu
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The position of the right TextInput.Affix is not calculated correctly when the onPress method is provided.
Related issue
#4407
Test plan
Run Example and add a right affix to TextInput with the onPress property. Affix should render the same as without onPress. You can also try the example from the related issue.
The first recording shows how the component behaves before the fix (without and with the onPress property). The second is the result after the fix.
before.mov
after.mov