fix(text-input): parent scroll with text input height #4422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform: Android only
Motivation
This pull request fixes two bugs that are related to each other.
mode="outlined"
withheight
style property blocks parent scroll.Screen.Recording.2024-05-28.at.11.50.53.mov
mode="outlined"
Left/right suffix is not correctly aligned to input when height style is providedmode="flat"
(default) blocks scrolling of the parent with a large font. The bug can be reproduced in the example app “Flat input large font”.Screen.Recording.2024-05-28.at.12.23.36.mov
Related issue
#1556, #4390,
Test plan
height
style of the Text input propFlat input large font
Recording below shows result with the fix:
Screen.Recording.2024-05-28.at.12.32.25.mov