Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-input): parent scroll with text input height #4422

Conversation

seb-zabielski
Copy link
Contributor

Platform: Android only

Motivation

This pull request fixes two bugs that are related to each other.

  1. TextInput mode="outlined" with height style property blocks parent scroll.
Screen.Recording.2024-05-28.at.11.50.53.mov
  1. mode="outlined" Left/right suffix is not correctly aligned to input when height style is provided
    Screenshot 2024-05-28 at 12 03 52 2

  2. mode="flat"(default) blocks scrolling of the parent with a large font. The bug can be reproduced in the example app “Flat input large font”.

Screen.Recording.2024-05-28.at.12.23.36.mov

Related issue

#1556, #4390,

Test plan

  1. To test issue 1 and 2 run example app and set height style of the Text input prop
  2. To test issue 3 run example app, and try to scroll starting from Flat input large font

Recording below shows result with the fix:

Screen.Recording.2024-05-28.at.12.32.25.mov

@callstack-bot
Copy link

Hey @seb-zabielski, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@gedu gedu added this to the 5.12.4 milestone May 28, 2024
@gedu
Copy link
Contributor

gedu commented Jun 4, 2024

LGTM

@gedu gedu self-requested a review June 4, 2024 08:43
@lukewalczak lukewalczak merged commit c1495ea into callstack:main Jul 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants