Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo in GENERIC_422_UNSUPPORTED_DEVICE_IDENTIFIERS - example #260

Open
maxl2287 opened this issue Sep 26, 2024 · 1 comment · May be fixed by #261
Open

Small typo in GENERIC_422_UNSUPPORTED_DEVICE_IDENTIFIERS - example #260

maxl2287 opened this issue Sep 26, 2024 · 1 comment · May be fixed by #261
Assignees

Comments

@maxl2287
Copy link
Contributor

Problem description
Incorrect reading in "Supported device supported are: ..."

            GENERIC_422_UNSUPPORTED_DEVICE_IDENTIFIERS:
              summary: None of the provided device identifiers is supported by the implementation
              description: Message may list the supported device identifiers
              value:
                status: 422
                code: UNSUPPORTED_DEVICE_IDENTIFIERS
                message: "Supported device supported are: ..."

Expected behavior

message: "Supported device identifiers are: ..."

Alternative solution

Without listing the supported device identifiers.

            GENERIC_422_UNSUPPORTED_DEVICE_IDENTIFIERS:
              summary: None of the provided device identifiers is supported by the implementation
              description: Message identifies that none of the provided device identifiers are supported
              value:
                status: 422
                code: UNSUPPORTED_DEVICE_IDENTIFIERS
                message: None of the provided device identifiers is supported by the implementation
@maxl2287 maxl2287 self-assigned this Sep 26, 2024
@jlurien
Copy link
Collaborator

jlurien commented Sep 27, 2024

It was copied from https://github.com/camaraproject/QualityOnDemand/blob/main/code/API_definitions/qod-provisioning.yaml#L963, we should open an issue there too, fyi @hdamker

As messages in errors are not normative, and implementations may return whatever other value, I think it is not strictly necessary to fix the past release for this, but if we have to make other fixes we can add it as well. But it is ok to fix the main branch in any case. This subcase of 422 was not listed in Commonalities but it would make sense to have a common example there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants