Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Archive::Extract does not respect $extract_dir #46

Open
rymndhng opened this issue Apr 14, 2015 · 3 comments
Open

Archive::Extract does not respect $extract_dir #46

rymndhng opened this issue Apr 14, 2015 · 3 comments

Comments

@rymndhng
Copy link

In the file extract.pp

      $extract_zip    = "unzip -o ${src_target}/${name}.${extension} -d ${target}"
      $extract_targz  = "tar --no-same-owner --no-same-permissions --strip-components=${strip_components} -xzf ${src_target}/${name}.${extension} -C ${target}"
      $extract_tarbz2 = "tar --no-same-owner --no-same-permissions --strip-components=${strip_components} -xjf ${src_target}/${name}.${extension} -C ${target}"

These ${target} should be ${extract_dir}

That said: I'm more concerned with how this module isn't consistent with how the parameters should be used. I much prefer having a single $target to extract to because that's conceptually easier to follow.

@joshuaspence
Copy link

+1

@aman-ttc
Copy link

aman-ttc commented Jun 8, 2015

+1.

What is the status of this? I can provide a PR if necessary

@aman-ttc
Copy link

aman-ttc commented Aug 8, 2015

bump...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants