Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defmacro doesn't properly munge dispatch values with periods #60

Closed
camsaul opened this issue Jun 10, 2021 · 0 comments · Fixed by #63
Closed

defmacro doesn't properly munge dispatch values with periods #60

camsaul opened this issue Jun 10, 2021 · 0 comments · Fixed by #63
Labels
bug Something isn't working high-priority! more important than the other issues
Milestone
0.11.4

Comments

@camsaul
Copy link
Owner

camsaul commented Jun 10, 2021

The dispatch value [:default :default :databird.honeysql] results in a method name like update-query*-primary-method-default-default-databird.honeysql which doesn't work since it contains a period. The name generation for defmethod should replace the period with an underscore or something.
@camsaul camsaul added bug Something isn't working high-priority! more important than the other issues labels Jun 10, 2021
@camsaul camsaul added this to the 0.11.4 milestone Jun 10, 2021
@camsaul camsaul mentioned this issue Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high-priority! more important than the other issues
Projects
None yet
Milestone
0.11.4
Development

Successfully merging a pull request may close this issue.

More robust logic for defmethod fn names generation camsaul/methodical
1 participant
@camsaul