Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching makes diagram shift down in the canvas #4547

Closed
GeethaParthasarathy opened this issue Sep 24, 2024 · 3 comments · Fixed by #4641
Closed

Searching makes diagram shift down in the canvas #4547

GeethaParthasarathy opened this issue Sep 24, 2024 · 3 comments · Fixed by #4641
Labels
bug Something isn't working DMN spring cleaning Could be cleaned up one day
Milestone

Comments

@GeethaParthasarathy
Copy link

GeethaParthasarathy commented Sep 24, 2024

Describe the bug

When you enter a search term it makes diagram shift down in the canvas

Steps to reproduce

  1. Create any diagram
  2. Press CTRL+F and enter a search term
  3. We could see that the diagram in the canvas is shifted down as it resolves to any element
Screen.Recording.2024-09-24.at.14.17.44.mov

Expected behavior

Diagram position should remain the same even when a element is resolved as a result of search

Environment

  • OS: [MacOS 10.2]
  • Camunda Modeler Version: [5.28.0.]
  • Execution Platform: [Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Sep 24, 2024
@barmac
Copy link
Collaborator

barmac commented Sep 26, 2024

I can reproduce this. It's not blocking the release.

@barmac barmac added DMN spring cleaning Could be cleaned up one day labels Sep 26, 2024
@barmac
Copy link
Collaborator

barmac commented Sep 26, 2024

@philippfromme Perhaps this is related to the recent changes in search?

@philippfromme
Copy link
Contributor

This is fixed upstream by bpmn-io/diagram-js#931.

@philippfromme philippfromme added the fixed upstream Requires integration of upstream change label Sep 27, 2024
@nikku nikku added the ready Ready to be worked on label Oct 29, 2024 — with bpmn-io-tasks
@nikku nikku removed the fixed upstream Requires integration of upstream change label Oct 29, 2024
@nikku nikku added this to the M82 milestone Oct 29, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Oct 29, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DMN spring cleaning Could be cleaned up one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants