Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multipass): parse dev multipass versions #662

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Sep 24, 2024

Fixes #661

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau marked this pull request as ready for review September 24, 2024 18:11
@lengau lengau force-pushed the work/661/CRAFT-3452/invalid-version branch from 8d5ab21 to 68e11d5 Compare September 25, 2024 13:54
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever fix!

craft_providers/multipass/multipass.py Show resolved Hide resolved
@lengau lengau changed the base branch from main to hotfix/2.0 September 26, 2024 15:29
@lengau lengau force-pushed the work/661/CRAFT-3452/invalid-version branch from 0268c5a to 73aab04 Compare September 26, 2024 15:31
@lengau lengau force-pushed the work/661/CRAFT-3452/invalid-version branch from 73aab04 to f1a062a Compare September 26, 2024 15:31
@lengau lengau merged commit 4e0ad35 into hotfix/2.0 Sep 26, 2024
10 of 11 checks passed
@lengau lengau deleted the work/661/CRAFT-3452/invalid-version branch September 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some multipass dev versions are considered invalid
3 participants