Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The kubeflow-dashboard charm integration tests do not test that the dashboard is accessible #189

Closed
NohaIhab opened this issue May 10, 2024 · 1 comment · Fixed by #199
Closed
Labels
bug Something isn't working

Comments

@NohaIhab
Copy link
Contributor

NohaIhab commented May 10, 2024

Bug Description

The current integration tests do not cover testing that the dashboard is accessible. This means that the integration tests can pass when the dashboard is in fact non functional.
This was exploited when the integration tests failed for dex-auth in canonical/dex-auth-operator#187, where test_login failed with timeout to reach the dashboard.
We should have a test to verify this in this repo since this can potentially break the bundle.

For example, the dashboard is now broken on juju 3.5 due to #188, and yet the integration tests passed for #182 and #183

To Reproduce

  1. Run the charm's integration tests withtox -e integration in main on Juju 3.5
  2. The tests pass
  3. Try to access the dashboard -> fail

Environment

juju 3.5/stable
microk8s 1.25-strict/stable

@NohaIhab NohaIhab added the bug Something isn't working label May 10, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5655.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant