Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(twa): Replace istio in integration tests #102

Open
orfeas-k opened this issue Feb 1, 2024 · 2 comments
Open

tests(twa): Replace istio in integration tests #102

orfeas-k opened this issue Feb 1, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@orfeas-k
Copy link
Contributor

orfeas-k commented Feb 1, 2024

Context

During canonical/bundle-kubeflow#621, it was agreed to test web apps charms by using the unit/k8s-svc IP directly instead of going through istio's ingressgateway. Thus, we should remove istio charms from integration tests. However, kubeflow-tensorboards-webapp charm needs ingress relation in order to be unblocked and go to active. Thus, it should be replaced instead by a test entity that will be able mock that relation.

By removing istio, tests will also be independent of istio charms' failures.

What needs to get done

  1. Remove istio from tensorboards-web-app
  2. Replace it with a mock charm that offers ingress relation to charm

Definition of Done

Charm's integration tests pass without deploying istio charms

@orfeas-k orfeas-k added the enhancement New feature or request label Feb 1, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5279.

This message was autogenerated

@orfeas-k
Copy link
Contributor Author

orfeas-k commented Feb 1, 2024

We could also replace istio in the repo's integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Labeled
Development

No branches or pull requests

1 participant