You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During canonical/bundle-kubeflow#621, it was agreed to test web apps charms by using the unit/k8s-svc IP directly instead of going through istio's ingressgateway. Thus, we should remove istio charms from integration tests. However, kubeflow-tensorboards-webapp charm needs ingress relation in order to be unblocked and go to active. Thus, it should be replaced instead by a test entity that will be able mock that relation.
By removing istio, tests will also be independent of istio charms' failures.
What needs to get done
Remove istio from tensorboards-web-app
Replace it with a mock charm that offers ingress relation to charm
Definition of Done
Charm's integration tests pass without deploying istio charms
The text was updated successfully, but these errors were encountered:
Context
During canonical/bundle-kubeflow#621, it was agreed to test web apps charms by using the unit/k8s-svc IP directly instead of going through istio's ingressgateway. Thus, we should remove istio charms from integration tests. However, kubeflow-tensorboards-webapp charm needs ingress relation in order to be unblocked and go to
active
. Thus, it should be replaced instead by a test entity that will be able mock that relation.By removing istio, tests will also be independent of istio charms' failures.
What needs to get done
ingress
relation to charmDefinition of Done
Charm's integration tests pass without deploying istio charms
The text was updated successfully, but these errors were encountered: