Merge pull request #15 from alesstimec/makefile-push-microk8s

Makefile push microk8s
canonical · Jul 5, 2023 · 9b8e056 · 9b8e056
2 parents 8485b6d + 6a4cd66
commit 9b8e056
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/Makefile b/Makefile
@@ -7,4 +7,6 @@ build-image:
 	docker build --target build \
 	--tag openfga:latest \
 	./images
-
+push-microk8s: build-image
+	docker tag openfga:latest localhost:32000/openfga:latest
+	docker push localhost:32000/openfga:latest
diff --git a/charms/openfga-k8s/lib/charms/openfga_k8s/v0/openfga.py b/charms/openfga-k8s/lib/charms/openfga_k8s/v0/openfga.py
@@ -54,8 +54,13 @@ def _on_openfga_store_created(self, event: OpenFGAStoreCreateEvent):
             secret = self.model.get_secret(id=event.token_secret_id)
             content = secret.get_content()
             # and get the token with content["token"]
+        if event.token:
+            # get the token from event.token
 ```
 
+As you can see the OpenFGA charm will attempt to use Juju secrets to pass the token
+to the requiring charm. However if the Juju version does not support secrets it will
+fall back to passing plaintext token via relation fata.
 """
 
 import logging

diff --git a/charms/openfga-k8s/tests/charms/openfga_requires/lib/charms/openfga_k8s/v0/openfga.py b/charms/openfga-k8s/tests/charms/openfga_requires/lib/charms/openfga_k8s/v0/openfga.py
@@ -54,8 +54,13 @@ def _on_openfga_store_created(self, event: OpenFGAStoreCreateEvent):
             secret = self.model.get_secret(id=event.token_secret_id)
             content = secret.get_content()
             # and get the token with content["token"]
+        if event.token:
+            # get the token from event.token
 ```
 
+As you can see the OpenFGA charm will attempt to use Juju secrets to pass the token
+to the requiring charm. However if the Juju version does not support secrets it will
+fall back to passing plaintext token via relation fata.
 """
 
 import logging