-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build, sign and publish registries #5072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
work/CRAFT-3331/publish-registries
branch
from
September 27, 2024 16:46
b2e26d3
to
a161e44
Compare
lengau
reviewed
Sep 27, 2024
lengau
reviewed
Sep 27, 2024
lengau
approved these changes
Sep 27, 2024
Signed-off-by: Callahan Kovacs <[email protected]>
tigarmo
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks fine to me. I understand that the spread tests are coming in a separate PR?
Signed-off-by: Callahan Kovacs <[email protected]>
Correct |
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
requested review from
tigarmo
and removed request for
cmatsuoka and
tigarmo
October 2, 2024 15:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)Finalizes support for the
edit-registries
command by building, signing and publishing registries.(CRAFT-3331)
Fixes #5018