Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix validation sets spread test #5075

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 27, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Behind the scenes, I updated the validation sets spread test to use the hello-world snap.

This PR flip-flops the presence instead of the revision, which should make it a little more robust because it won't depend on a specific revision of the snap being accessible.

Fixes #5053
(CRAFT-3418)

@mr-cal mr-cal marked this pull request as ready for review September 27, 2024 16:23
@sergiusens
Copy link
Collaborator

errors are unrelated

@sergiusens sergiusens force-pushed the work/CRAFT-3418/validation-sets-spread-test branch from bce5c43 to c9963f0 Compare September 30, 2024 18:08
@sergiusens sergiusens enabled auto-merge (rebase) September 30, 2024 18:09
@sergiusens sergiusens merged commit a22b218 into main Sep 30, 2024
12 of 13 checks passed
@sergiusens sergiusens deleted the work/CRAFT-3418/validation-sets-spread-test branch September 30, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix validation-sets spread test
3 participants