Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify exotic hardware requirements #62

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

cpaelzer
Copy link
Collaborator

Be less misunderstandbale (we mean the HW not the PKG) and provide a few examples so requestors know what an answer might look like.

Fixes: #61

This comment has been minimized.

Be less misunderstandbale (we mean the HW not the PKG) and provide
a few examples so users know what kind of answer we look for.

Fixes: canonical#61

Signed-off-by: Christian Ehrhardt <[email protected]>
Copy link

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way clearer to me, thanks for drafting this!

Copy link
Contributor

@setharnold setharnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small stylistic suggestion, a colon.

README.md Outdated Show resolved Hide resolved
The only other case of a TODO getting subspecified with options today
is ending in a colon and then the sub-elements have a wider indent.
Keep the same style here.

Signed-off-by: Christian Ehrhardt <[email protected]>
Copy link
Contributor

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@slyon
Copy link
Contributor

slyon commented Aug 20, 2024

This is looking all good. Let's get it merged!

@slyon slyon merged commit cd9cf95 into canonical:main Aug 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The package does deal with exotic hardware, it is present at TBD
4 participants