Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predicate standardization #1041

Merged
merged 2 commits into from
Feb 27, 2016
Merged

Predicate standardization #1041

merged 2 commits into from
Feb 27, 2016

Conversation

aearly
Copy link
Collaborator

@aearly aearly commented Feb 27, 2016

Closes #118

The work was actually done concurrently with modularization, I forgot about that! This PR just separates out the tests for filter/reject/detect/every/some and converts them to mocha/chai. I did discover that one test failed after I converted it (it was testing the wrong thing). It makes me wonder if nodeunit is hiding any more deficiencies...

@aearly aearly added this to the 2.0 milestone Feb 27, 2016
aearly added a commit that referenced this pull request Feb 27, 2016
@aearly aearly merged commit 0440883 into master Feb 27, 2016
@megawac megawac deleted the predicate-standardization branch April 12, 2016 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant