From 8b190d16cf40d51d51ab6a88685c1980e49d8f98 Mon Sep 17 00:00:00 2001 From: GoethelHB <134271948+GoethelHB@users.noreply.github.com> Date: Fri, 20 Sep 2024 11:07:49 +0200 Subject: [PATCH] fix(crashlytics): `crash(...)` method now respects message option (#721) * bugfix-firebase-crashlytics-iOS-testCrash-not-passing-message-option-#720 * npm run changeset * Update thin-hornets-explain.md --------- Co-authored-by: Robin Genz --- .changeset/thin-hornets-explain.md | 5 +++++ packages/crashlytics/ios/Plugin/FirebaseCrashlytics.swift | 4 ++-- .../crashlytics/ios/Plugin/FirebaseCrashlyticsPlugin.swift | 6 +++++- 3 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 .changeset/thin-hornets-explain.md diff --git a/.changeset/thin-hornets-explain.md b/.changeset/thin-hornets-explain.md new file mode 100644 index 00000000..4be0441f --- /dev/null +++ b/.changeset/thin-hornets-explain.md @@ -0,0 +1,5 @@ +--- +'@capacitor-firebase/crashlytics': patch +--- + +fix(ios): `crash(...)` method now respects message option diff --git a/packages/crashlytics/ios/Plugin/FirebaseCrashlytics.swift b/packages/crashlytics/ios/Plugin/FirebaseCrashlytics.swift index 94006948..d952bfa2 100644 --- a/packages/crashlytics/ios/Plugin/FirebaseCrashlytics.swift +++ b/packages/crashlytics/ios/Plugin/FirebaseCrashlytics.swift @@ -10,8 +10,8 @@ import FirebaseCrashlytics } } - @objc public func crash() { - fatalError() + @objc public func crash(_ message: String) { + fatalError(message) } @objc func setCustomKey(_ key: String, _ type: String, _ call: CAPPluginCall) { diff --git a/packages/crashlytics/ios/Plugin/FirebaseCrashlyticsPlugin.swift b/packages/crashlytics/ios/Plugin/FirebaseCrashlyticsPlugin.swift index 0d35e066..5e168871 100644 --- a/packages/crashlytics/ios/Plugin/FirebaseCrashlyticsPlugin.swift +++ b/packages/crashlytics/ios/Plugin/FirebaseCrashlyticsPlugin.swift @@ -19,8 +19,12 @@ public class FirebaseCrashlyticsPlugin: CAPPlugin { } @objc func crash(_ call: CAPPluginCall) { + guard let message = call.getString("message") else { + call.reject(errorMessageMissing) + return + } call.resolve() - implementation?.crash() + implementation?.crash(message) } @objc func setCustomKey(_ call: CAPPluginCall) {