Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootstrap cache configurable #13

Closed
kingcrunch opened this issue Apr 18, 2014 · 1 comment
Closed

Make bootstrap cache configurable #13

kingcrunch opened this issue Apr 18, 2014 · 1 comment
Assignees

Comments

@kingcrunch
Copy link

Hi, it's me again. I've seen a TODO

task :build_bootstrap do
  on release_roles :all do
    within release_path do
      # TODO: does this need to be configurable?
      execute :php, "./vendor/sensio/distribution-bundle/Sensio/Bundle/DistributionBundle/Resources/bin/build_bootstrap.php", fetch(:app_path)
    end
  end
end

I'd say yes. Actually only because I consider dropping the bootstrap-cache entirely, because

  • It is the only "part" of the DistributionBundle I use, so I'd like to drop that bundle
  • It looses it's benefit, when there is a proper bytecode cache with constant stat-calls

Right now I cannot drop the bundle, because it would break the deployment (as far as I've seen I cannot remove tasks from the flow, right?)

@peterjmit peterjmit self-assigned this Apr 20, 2014
@peterjmit
Copy link
Contributor

As mentioned in #17 you can remove a task from the deployment, it should not cause a problem

Rake::Task['deploy:build_bootstrap'].clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants