Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor storage package to focus on how to update instead of what to update #490

Open
ariefrahmansyah opened this issue Nov 17, 2023 · 0 comments

Comments

@ariefrahmansyah
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Model Endpoint Storage's Save method in the storage package has a logic on what and how to update both model endpoint and model version endpoint. This could lead to confusion on how to implement service and storage layer in the future.

Related discussion: #483 (comment)

Describe the solution you'd like

  • A clear separation and guideline for service and storage layer's responsibilties
  • Refactor storage layer to be more responsible on how to update the data and let service layer decide what to save
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant