Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoalign): fix autoalign CSB example #11572

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix(autoalign): fix autoalign CSB example #11572

merged 1 commit into from
Feb 22, 2024

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Feb 22, 2024 •
edited
Loading

Related Ticket(s)

Closes # N/A

Description

Codesandbox example was displaying errors - this PR adds the .sassrc file necessary for the styles to be imported correctly and adjustments to the click function for the popover as optional chaining isn't supported in the codesandbox example

Changelog

New

  • {{new thing}}

Changed

  • {{changed thing}}

Removed

  • {{removed thing}}

@annawen1 annawen1 requested a review from a team as a code owner February 22, 2024 16:46
@annawen1 annawen1 added documentation Improvements or additions to documentation package: carbon web components labels Feb 22, 2024
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11572/index.html

Built with commit: 112c088f76fd91b041bf44cac2cba4084ff93ae2

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11572/index.html

Built with commit: 112c088f76fd91b041bf44cac2cba4084ff93ae2

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11572/index.html

Built with commit: 112c088f76fd91b041bf44cac2cba4084ff93ae2

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11572/index.html

Built with commit: 112c088f76fd91b041bf44cac2cba4084ff93ae2

@annawen1 annawen1 merged commit bf6ccfb into carbon-design-system:release/v2.4.0 Feb 22, 2024
12 of 19 checks passed
@annawen1 annawen1 deleted the fix/autoalign-codesandbox-example branch February 22, 2024 20:24
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
@annawen1 @kennylam
fix(autoalign): fix autoalign CSB example (carbon-design-system#11572)
5aa4ae9
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@annawen1
fix(autoalign): fix autoalign CSB example (carbon-design-system#11572)
aa9939f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@emyarod emyarod Awaiting requested review from emyarod emyarod was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: carbon web components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annawen1 @ibmdotcom-bot @ariellalgilmore