Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a11y - ensure side panel closes properly with reduced motion #11608

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: a11y - ensure side panel closes properly with reduced motion #11608

merged 2 commits into from
Mar 5, 2024

Conversation

lee-chase
Copy link
Member

Related Ticket(s)

Description

With reduce motion enabled the side panel was left in a state where it was waiting for a transition to end before completing the close. There is not transition with reduced motion, and as a result a transparent pane was left over the rest of the page.

This PR corrects that to ensure the side panel is correctly closed when reduced motion is enabled.

Changelog

Changed

  • packages/carbon-web-components/src/components/side-panel/side-panel.ts

@lee-chase lee-chase requested a review from a team as a code owner March 1, 2024 09:46
@lee-chase lee-chase requested review from IgnacioBecerra and sangeethababu9223 and removed request for a team March 1, 2024 09:46
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 1, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11608/index.html

Built with commit: 57bcb444e4b5d3db7e80b4b311d29d2b2e0a4e0e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 1, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11608/index.html

Built with commit: 57bcb444e4b5d3db7e80b4b311d29d2b2e0a4e0e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 1, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11608/index.html

Built with commit: 57bcb444e4b5d3db7e80b4b311d29d2b2e0a4e0e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 1, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11608/index.html

Built with commit: 57bcb444e4b5d3db7e80b4b311d29d2b2e0a4e0e

@annawen1 annawen1 changed the base branch from main to release/v2.5.0 March 1, 2024 18:08
@lee-chase lee-chase mentioned this pull request Mar 4, 2024
Closed
annawen1
annawen1 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@annawen1 annawen1 added package: carbon web components Ready to merge Label for the pull requests that are ready to merge labels Mar 4, 2024
@ariellalgilmore ariellalgilmore merged commit dbddbb0 into carbon-design-system:release/v2.5.0 Mar 5, 2024
12 of 20 checks passed
@annawen1
Copy link
Member

Hey there! This issue/pull request was referenced in recently released v2.5.0.

kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@lee-chase @annawen1
fix: reduced motion side panel close (carbon-design-system#11608)
42d55dd 
Co-authored-by: Anna Wen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lee-chase @ibmdotcom-bot @annawen1 @ariellalgilmore