Skip to content

Commit

Permalink
fix(button): remove margin added by safari (#5169)
Browse files Browse the repository at this point in the history
* fix(button): remove margin added by safari

* fix(button): add button fix to reset file as well

* fix(button): make margin reset less browser specific
  • Loading branch information
tw15egan authored Jan 29, 2020
1 parent 104eddb commit 2ce57b3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/components/src/components/button/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
outline: none;
position: relative;
max-width: rem(320px);
// Fix to remove added margins on buttons in safari (see #5155)
margin: 0;

&:disabled,
&.#{$prefix}--btn--disabled {
Expand Down
5 changes: 5 additions & 0 deletions packages/components/src/globals/scss/_css--reset.scss
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,11 @@
box-sizing: border-box;
}

// Fix to remove added margins on buttons in safari (see #5155)
button {
margin: 0;
}

@include carbon--type-reset;
@include carbon--icons;
}
Expand Down

0 comments on commit 2ce57b3

Please sign in to comment.