From 43f6731decc5a7c5362c48b7afb6b6046b9d0a8e Mon Sep 17 00:00:00 2001 From: TJ Egan Date: Mon, 15 Apr 2024 07:30:51 -0700 Subject: [PATCH 1/9] docs(@carbon/colors): Update carbon colors documentation (#16193) * docs(@carbon/colors): update documentation for v11 * docs(@carbon/colors): update more documentation --- packages/colors/README.md | 79 +++++++-------------------------------- 1 file changed, 13 insertions(+), 66 deletions(-) diff --git a/packages/colors/README.md b/packages/colors/README.md index 5eef68273d75..82f39fdf43ea 100644 --- a/packages/colors/README.md +++ b/packages/colors/README.md @@ -28,56 +28,31 @@ Sass. In Sass, you can import the files individual by doing: ```scss -@import '@carbon/colors/scss/colors'; -``` - -This file automatically includes the `carbon--colors` mixin which initializes -all the color variables for the IBM Design Language. - -These color variables follow the naming convention: `$carbon---`. -For example: +@use '@carbon/colors'; -```scss -$carbon--blue-50; -$carbon--cool-gray-10; -$carbon--black-100; -$carbon--white-0; +// Another way if using `@carbon/react +@use '@carbon/react/scss/colors'; ``` -You can also use the shorthand form of these colors by dropping the `carbon--` -namespace: +These color variables follow the naming convention: `-`. For +example: ```scss -$blue-50; -$cool-gray-10; -$black-100; -$white-0; -``` - -_Note: the shorthand variables require that you do not have any other -conflicting variables in your setup. Namespaced variables are always preferred -for this reason, unless you are confident that no collisions will occur._ - -If you would like you choose when these variables are defined, then you can call -the `carbon--colors` mixin directly by importing the following file: - -```scss -@import '@carbon/colors/scss/mixins'; - -// ... -@include carbon--colors(); +colors.$blue-50; +colors.$cool-gray-10; +colors.$black-100; +colors.$white-0; ``` Alongside the color variables detailed above, we also provide a map of colors so -that you can programmatically use these values. This map is called -`$carbon--colors` and each key is the name of a swatch. The value of these -swatches is also a map, but each key is now the grade. In code, this looks like -the following: +that you can programmatically use these values. This map is called `$colors` and +each key is the name of a swatch. The value of these swatches is also a map, but +each key is now the grade. In code, this looks like the following: ```scss -$carbon--colors: ( +$colors: ( 'blue': ( 10: #edf4ff, // ... @@ -87,34 +62,6 @@ $carbon--colors: ( -You can include this variable by including `@carbon/colors/scss/colors` or -calling the `carbon--colors()` mixin directly. - -#### Migrating from previous versions - -If you were originally using a project that had color variables defined as -`$ibm-color__-`, or are relying on `$ibm-color-map`, you can also -use the entrypoint described above to access these colors. They are meant as an -easier way to help adopt these packages. However, these variables will be -removed in the next release of Carbon. - -Similar to previous efforts, we also provide colors in the formats mentioned -above. For example: - -```scss -$ibm-color__blue-50; -$ibm-color__warm-gray-100; -``` - -If you would like a mixin to conditionally include these variables, you can -include the mixin by using: - -```scss -@import '@carbon/colors/scss/mixins'; - -@include ibm--colors(); -``` - ### JavaScript For JavaScript, you can import and use this module by doing the following in From 9f59cc2cef2721dc4fe128b8bd0af45b03ce4bb5 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 15 Apr 2024 10:42:58 -0400 Subject: [PATCH 2/9] chore(deps): bump github/codeql-action from 3.24.10 to 3.25.0 (#16203) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.10 to 3.25.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/4355270be187e1b672a7a1c7c7bae5afdc1ab94a...df5a14dc28094dc936e103b37d749c6628682b60) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/codeql-analysis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index c680c7523f0a..ae693e99fc90 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -24,9 +24,9 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@4355270be187e1b672a7a1c7c7bae5afdc1ab94a # v3.24.10 + uses: github/codeql-action/init@df5a14dc28094dc936e103b37d749c6628682b60 # v3.25.0 with: languages: javascript - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@4355270be187e1b672a7a1c7c7bae5afdc1ab94a # v3.24.10 + uses: github/codeql-action/analyze@df5a14dc28094dc936e103b37d749c6628682b60 # v3.25.0 From f4c5ac366652c9e14332de5bf3b3240ccdf5d63b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 15 Apr 2024 13:14:49 -0300 Subject: [PATCH 3/9] chore(deps): update peter-evans/create-pull-request action to v6.0.3 (#16195) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .github/workflows/deploy-packages.yml | 4 ++-- .github/workflows/version.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/deploy-packages.yml b/.github/workflows/deploy-packages.yml index afadc1770eb9..510863149ce9 100644 --- a/.github/workflows/deploy-packages.yml +++ b/.github/workflows/deploy-packages.yml @@ -39,7 +39,7 @@ jobs: app_id: ${{ secrets.APP_ID }} private_key: ${{ secrets.APP_PRIVATE_KEY }} - name: Create Pull Request - uses: peter-evans/create-pull-request@70a41aba780001da0a30141984ae2a0c95d8704e #v6.0.2 + uses: peter-evans/create-pull-request@c55203cfde3e5c11a452d352b4393e68b85b4533 # v6.0.3 with: branch: 'release/update-carbon-deps' commit-message: 'chore(release): update carbon deps' @@ -82,7 +82,7 @@ jobs: app_id: ${{ secrets.APP_ID }} private_key: ${{ secrets.APP_PRIVATE_KEY }} - name: Create Pull Request - uses: peter-evans/create-pull-request@70a41aba780001da0a30141984ae2a0c95d8704e #v6.0.2 + uses: peter-evans/create-pull-request@c55203cfde3e5c11a452d352b4393e68b85b4533 # v6.0.3 with: branch: 'release/update-carbon-deps' commit-message: 'chore(release): update carbon deps' diff --git a/.github/workflows/version.yml b/.github/workflows/version.yml index 69a9b8806c25..72a9c660ab98 100644 --- a/.github/workflows/version.yml +++ b/.github/workflows/version.yml @@ -64,7 +64,7 @@ jobs: app_id: ${{ secrets.APP_ID }} private_key: ${{ secrets.APP_PRIVATE_KEY }} - name: Create Pull Request - uses: peter-evans/create-pull-request@70a41aba780001da0a30141984ae2a0c95d8704e #v6.0.2 + uses: peter-evans/create-pull-request@c55203cfde3e5c11a452d352b4393e68b85b4533 # v6.0.3 with: branch: 'release/${{ github.event.inputs.tag }}' commit-message: 'chore(release): ${{ github.event.inputs.tag }}' From cc4734850554d6010c7d45d0df3ef9fd4da7f03c Mon Sep 17 00:00:00 2001 From: conradennis Date: Mon, 15 Apr 2024 12:30:27 -0400 Subject: [PATCH 4/9] feat(icons): new shapes icons (#16190) * feat(icons): new shapes icons Submitting new shapes UI icons All updates and additions approved by BXD 25 net new icons Updated categories.yml and icons.yml files * fix(Icons): fix type, scaffold out metadata --------- Co-authored-by: TJ Egan --- .../__snapshots__/PublicAPI-test.js.snap | 25 ++ .../__snapshots__/PublicAPI-test.js.snap | 100 ++++++ .../__snapshots__/PublicAPI-test.js.snap | 100 ++++++ packages/icons/categories.yml | 25 ++ packages/icons/icons.yml | 317 +++++++++++++++++- packages/icons/src/svg/32/circle--outline.svg | 16 + .../icons/src/svg/32/diamond--outline.svg | 16 + packages/icons/src/svg/32/diamond--solid.svg | 16 + .../icons/src/svg/32/hexagon--outline.svg | 16 + packages/icons/src/svg/32/hexagon--solid.svg | 16 + .../src/svg/32/hexagon--vertical--outline.svg | 16 + .../src/svg/32/hexagon--vertical--solid.svg | 16 + .../src/svg/32/pentagon--down--outline.svg | 16 + .../src/svg/32/pentagon--down--solid.svg | 16 + .../src/svg/32/pentagon--left--outline.svg | 16 + .../src/svg/32/pentagon--left--solid.svg | 16 + .../icons/src/svg/32/pentagon--outline.svg | 16 + .../src/svg/32/pentagon--right--outline.svg | 16 + .../src/svg/32/pentagon--right--solid.svg | 16 + packages/icons/src/svg/32/pentagon--solid.svg | 16 + packages/icons/src/svg/32/square--outline.svg | 16 + packages/icons/src/svg/32/square--solid.svg | 16 + .../src/svg/32/triangle--down--outline.svg | 16 + .../src/svg/32/triangle--down--solid.svg | 16 + .../src/svg/32/triangle--left--outline.svg | 16 + .../src/svg/32/triangle--left--solid.svg | 16 + .../icons/src/svg/32/triangle--outline.svg | 16 + .../src/svg/32/triangle--right--outline.svg | 16 + .../src/svg/32/triangle--right--solid.svg | 16 + packages/icons/src/svg/32/triangle--solid.svg | 16 + 30 files changed, 965 insertions(+), 2 deletions(-) create mode 100644 packages/icons/src/svg/32/circle--outline.svg create mode 100644 packages/icons/src/svg/32/diamond--outline.svg create mode 100644 packages/icons/src/svg/32/diamond--solid.svg create mode 100644 packages/icons/src/svg/32/hexagon--outline.svg create mode 100644 packages/icons/src/svg/32/hexagon--solid.svg create mode 100644 packages/icons/src/svg/32/hexagon--vertical--outline.svg create mode 100644 packages/icons/src/svg/32/hexagon--vertical--solid.svg create mode 100644 packages/icons/src/svg/32/pentagon--down--outline.svg create mode 100644 packages/icons/src/svg/32/pentagon--down--solid.svg create mode 100644 packages/icons/src/svg/32/pentagon--left--outline.svg create mode 100644 packages/icons/src/svg/32/pentagon--left--solid.svg create mode 100644 packages/icons/src/svg/32/pentagon--outline.svg create mode 100644 packages/icons/src/svg/32/pentagon--right--outline.svg create mode 100644 packages/icons/src/svg/32/pentagon--right--solid.svg create mode 100644 packages/icons/src/svg/32/pentagon--solid.svg create mode 100644 packages/icons/src/svg/32/square--outline.svg create mode 100644 packages/icons/src/svg/32/square--solid.svg create mode 100644 packages/icons/src/svg/32/triangle--down--outline.svg create mode 100644 packages/icons/src/svg/32/triangle--down--solid.svg create mode 100644 packages/icons/src/svg/32/triangle--left--outline.svg create mode 100644 packages/icons/src/svg/32/triangle--left--solid.svg create mode 100644 packages/icons/src/svg/32/triangle--outline.svg create mode 100644 packages/icons/src/svg/32/triangle--right--outline.svg create mode 100644 packages/icons/src/svg/32/triangle--right--solid.svg create mode 100644 packages/icons/src/svg/32/triangle--solid.svg diff --git a/e2e/icons-react/__snapshots__/PublicAPI-test.js.snap b/e2e/icons-react/__snapshots__/PublicAPI-test.js.snap index 08a5da98b599..945744abf258 100644 --- a/e2e/icons-react/__snapshots__/PublicAPI-test.js.snap +++ b/e2e/icons-react/__snapshots__/PublicAPI-test.js.snap @@ -350,6 +350,7 @@ Array [ "CircleDash", "CircleFill", "CircleFilled", + "CircleOutline", "CirclePacking", "CircleSolid", "CircleStroke", @@ -558,6 +559,8 @@ Array [ "Diagram", "DiagramReference", "DiamondFill", + "DiamondOutline", + "DiamondSolid", "DirectLink", "DirectionBearRight_01", "DirectionBearRight_01Filled", @@ -838,6 +841,10 @@ Array [ "Help", "HelpDesk", "HelpFilled", + "HexagonOutline", + "HexagonSolid", + "HexagonVerticalOutline", + "HexagonVerticalSolid", "Home", "HorizontalView", "Hospital", @@ -1394,6 +1401,14 @@ Array [ "PenFountain", "Pending", "PendingFilled", + "PentagonDownOutline", + "PentagonDownSolid", + "PentagonLeftOutline", + "PentagonLeftSolid", + "PentagonOutline", + "PentagonRightOutline", + "PentagonRightSolid", + "PentagonSolid", "Percentage", "PercentageFilled", "Person", @@ -1726,6 +1741,8 @@ Array [ "Sprout", "Sql", "SquareFill", + "SquareOutline", + "SquareSolid", "StackLimitation", "Stamp", "Star", @@ -1916,6 +1933,14 @@ Array [ "TreeFallRisk", "TreeView", "TreeViewAlt", + "TriangleDownOutline", + "TriangleDownSolid", + "TriangleLeftOutline", + "TriangleLeftSolid", + "TriangleOutline", + "TriangleRightOutline", + "TriangleRightSolid", + "TriangleSolid", "Trophy", "TrophyFilled", "TropicalStorm", diff --git a/e2e/icons-vue/__snapshots__/PublicAPI-test.js.snap b/e2e/icons-vue/__snapshots__/PublicAPI-test.js.snap index 20b9b4a9310f..6f4dd3ee20a0 100644 --- a/e2e/icons-vue/__snapshots__/PublicAPI-test.js.snap +++ b/e2e/icons-vue/__snapshots__/PublicAPI-test.js.snap @@ -1394,6 +1394,10 @@ Array [ "CircleFilled20", "CircleFilled24", "CircleFilled32", + "CircleOutline16", + "CircleOutline20", + "CircleOutline24", + "CircleOutline32", "CirclePacking16", "CirclePacking20", "CirclePacking24", @@ -2214,6 +2218,14 @@ Array [ "DiagramReference24", "DiagramReference32", "DiamondFillGlyph", + "DiamondOutline16", + "DiamondOutline20", + "DiamondOutline24", + "DiamondOutline32", + "DiamondSolid16", + "DiamondSolid20", + "DiamondSolid24", + "DiamondSolid32", "DirectLink16", "DirectLink20", "DirectLink24", @@ -3334,6 +3346,22 @@ Array [ "HelpFilled20", "HelpFilled24", "HelpFilled32", + "HexagonOutline16", + "HexagonOutline20", + "HexagonOutline24", + "HexagonOutline32", + "HexagonSolid16", + "HexagonSolid20", + "HexagonSolid24", + "HexagonSolid32", + "HexagonVerticalOutline16", + "HexagonVerticalOutline20", + "HexagonVerticalOutline24", + "HexagonVerticalOutline32", + "HexagonVerticalSolid16", + "HexagonVerticalSolid20", + "HexagonVerticalSolid24", + "HexagonVerticalSolid32", "Home16", "Home20", "Home24", @@ -5552,6 +5580,38 @@ Array [ "PendingFilled20", "PendingFilled24", "PendingFilled32", + "PentagonDownOutline16", + "PentagonDownOutline20", + "PentagonDownOutline24", + "PentagonDownOutline32", + "PentagonDownSolid16", + "PentagonDownSolid20", + "PentagonDownSolid24", + "PentagonDownSolid32", + "PentagonLeftOutline16", + "PentagonLeftOutline20", + "PentagonLeftOutline24", + "PentagonLeftOutline32", + "PentagonLeftSolid16", + "PentagonLeftSolid20", + "PentagonLeftSolid24", + "PentagonLeftSolid32", + "PentagonOutline16", + "PentagonOutline20", + "PentagonOutline24", + "PentagonOutline32", + "PentagonRightOutline16", + "PentagonRightOutline20", + "PentagonRightOutline24", + "PentagonRightOutline32", + "PentagonRightSolid16", + "PentagonRightSolid20", + "PentagonRightSolid24", + "PentagonRightSolid32", + "PentagonSolid16", + "PentagonSolid20", + "PentagonSolid24", + "PentagonSolid32", "Percentage16", "Percentage20", "Percentage24", @@ -6877,6 +6937,14 @@ Array [ "Sql24", "Sql32", "SquareFillGlyph", + "SquareOutline16", + "SquareOutline20", + "SquareOutline24", + "SquareOutline32", + "SquareSolid16", + "SquareSolid20", + "SquareSolid24", + "SquareSolid32", "StackLimitation16", "StackLimitation20", "StackLimitation24", @@ -7637,6 +7705,38 @@ Array [ "TreeViewAlt20", "TreeViewAlt24", "TreeViewAlt32", + "TriangleDownOutline16", + "TriangleDownOutline20", + "TriangleDownOutline24", + "TriangleDownOutline32", + "TriangleDownSolid16", + "TriangleDownSolid20", + "TriangleDownSolid24", + "TriangleDownSolid32", + "TriangleLeftOutline16", + "TriangleLeftOutline20", + "TriangleLeftOutline24", + "TriangleLeftOutline32", + "TriangleLeftSolid16", + "TriangleLeftSolid20", + "TriangleLeftSolid24", + "TriangleLeftSolid32", + "TriangleOutline16", + "TriangleOutline20", + "TriangleOutline24", + "TriangleOutline32", + "TriangleRightOutline16", + "TriangleRightOutline20", + "TriangleRightOutline24", + "TriangleRightOutline32", + "TriangleRightSolid16", + "TriangleRightSolid20", + "TriangleRightSolid24", + "TriangleRightSolid32", + "TriangleSolid16", + "TriangleSolid20", + "TriangleSolid24", + "TriangleSolid32", "Trophy16", "Trophy20", "Trophy24", diff --git a/e2e/icons/__snapshots__/PublicAPI-test.js.snap b/e2e/icons/__snapshots__/PublicAPI-test.js.snap index 0c547b7b34f6..6178490b91c7 100644 --- a/e2e/icons/__snapshots__/PublicAPI-test.js.snap +++ b/e2e/icons/__snapshots__/PublicAPI-test.js.snap @@ -1393,6 +1393,10 @@ Array [ "CircleFilled20", "CircleFilled24", "CircleFilled32", + "CircleOutline16", + "CircleOutline20", + "CircleOutline24", + "CircleOutline32", "CirclePacking16", "CirclePacking20", "CirclePacking24", @@ -2213,6 +2217,14 @@ Array [ "DiagramReference24", "DiagramReference32", "DiamondFillGlyph", + "DiamondOutline16", + "DiamondOutline20", + "DiamondOutline24", + "DiamondOutline32", + "DiamondSolid16", + "DiamondSolid20", + "DiamondSolid24", + "DiamondSolid32", "DirectLink16", "DirectLink20", "DirectLink24", @@ -3333,6 +3345,22 @@ Array [ "HelpFilled20", "HelpFilled24", "HelpFilled32", + "HexagonOutline16", + "HexagonOutline20", + "HexagonOutline24", + "HexagonOutline32", + "HexagonSolid16", + "HexagonSolid20", + "HexagonSolid24", + "HexagonSolid32", + "HexagonVerticalOutline16", + "HexagonVerticalOutline20", + "HexagonVerticalOutline24", + "HexagonVerticalOutline32", + "HexagonVerticalSolid16", + "HexagonVerticalSolid20", + "HexagonVerticalSolid24", + "HexagonVerticalSolid32", "Home16", "Home20", "Home24", @@ -5551,6 +5579,38 @@ Array [ "PendingFilled20", "PendingFilled24", "PendingFilled32", + "PentagonDownOutline16", + "PentagonDownOutline20", + "PentagonDownOutline24", + "PentagonDownOutline32", + "PentagonDownSolid16", + "PentagonDownSolid20", + "PentagonDownSolid24", + "PentagonDownSolid32", + "PentagonLeftOutline16", + "PentagonLeftOutline20", + "PentagonLeftOutline24", + "PentagonLeftOutline32", + "PentagonLeftSolid16", + "PentagonLeftSolid20", + "PentagonLeftSolid24", + "PentagonLeftSolid32", + "PentagonOutline16", + "PentagonOutline20", + "PentagonOutline24", + "PentagonOutline32", + "PentagonRightOutline16", + "PentagonRightOutline20", + "PentagonRightOutline24", + "PentagonRightOutline32", + "PentagonRightSolid16", + "PentagonRightSolid20", + "PentagonRightSolid24", + "PentagonRightSolid32", + "PentagonSolid16", + "PentagonSolid20", + "PentagonSolid24", + "PentagonSolid32", "Percentage16", "Percentage20", "Percentage24", @@ -6876,6 +6936,14 @@ Array [ "Sql24", "Sql32", "SquareFillGlyph", + "SquareOutline16", + "SquareOutline20", + "SquareOutline24", + "SquareOutline32", + "SquareSolid16", + "SquareSolid20", + "SquareSolid24", + "SquareSolid32", "StackLimitation16", "StackLimitation20", "StackLimitation24", @@ -7636,6 +7704,38 @@ Array [ "TreeViewAlt20", "TreeViewAlt24", "TreeViewAlt32", + "TriangleDownOutline16", + "TriangleDownOutline20", + "TriangleDownOutline24", + "TriangleDownOutline32", + "TriangleDownSolid16", + "TriangleDownSolid20", + "TriangleDownSolid24", + "TriangleDownSolid32", + "TriangleLeftOutline16", + "TriangleLeftOutline20", + "TriangleLeftOutline24", + "TriangleLeftOutline32", + "TriangleLeftSolid16", + "TriangleLeftSolid20", + "TriangleLeftSolid24", + "TriangleLeftSolid32", + "TriangleOutline16", + "TriangleOutline20", + "TriangleOutline24", + "TriangleOutline32", + "TriangleRightOutline16", + "TriangleRightOutline20", + "TriangleRightOutline24", + "TriangleRightOutline32", + "TriangleRightSolid16", + "TriangleRightSolid20", + "TriangleRightSolid24", + "TriangleRightSolid32", + "TriangleSolid16", + "TriangleSolid20", + "TriangleSolid24", + "TriangleSolid32", "Trophy16", "Trophy20", "Trophy24", diff --git a/packages/icons/categories.yml b/packages/icons/categories.yml index f82097710196..245f89fa1cd1 100644 --- a/packages/icons/categories.yml +++ b/packages/icons/categories.yml @@ -118,6 +118,7 @@ categories: - bring-to-front - button--centered - button--flush-left + - circle--outline - circle--solid - color-palette - color-switch @@ -128,6 +129,8 @@ categories: - crop - cut - cut-out + - diamond--outline + - diamond--solid - distribute--horizontal-center - distribute--horizontal-left - distribute--horizontal-right @@ -148,6 +151,10 @@ categories: - group-objects - group-objects--new - group-objects--save + - hexagon--outline + - hexagon--solid + - hexagon--vertical--outline + - hexagon--vertical--solid - horizontal-view - image - image--copy @@ -174,6 +181,14 @@ categories: - paragraph - pen - pen--fountain + - pentagon--down--outline + - pentagon--down--solid + - pentagon--left--outline + - pentagon--left--solid + - pentagon--outline + - pentagon--right--outline + - pentagon--right--solid + - pentagon--solid - percentage - percentage--filled - quotes @@ -201,6 +216,8 @@ categories: - shape--unite - spell-check - spray-paint + - square--outline + - square--solid - text--align--center - text--align--left - text--align--justify @@ -236,6 +253,14 @@ categories: - text--vertical-alignment - text--wrap - trash-can + - triangle--down--outline + - triangle--down--solid + - triangle--left--outline + - triangle--left--solid + - triangle--outline + - triangle--right--outline + - triangle--right--solid + - triangle--solid - ungroup-objects - unlink - unsaved diff --git a/packages/icons/icons.yml b/packages/icons/icons.yml index 139417284281..4b17ca0be3bb 100644 --- a/packages/icons/icons.yml +++ b/packages/icons/icons.yml @@ -4286,12 +4286,29 @@ - data sizes: - 32 +- name: circle--outline + friendly_name: Circle outline + aliases: + - circle outlined + - outlined circle + - stroke + - border + - circle + - round + - shape + - geometry + sizes: + - 32 - name: circle--solid friendly_name: Circle solid aliases: - circle filled - filled circle + - solid - circle + - round + - shape + - geometry - data sizes: - 32 @@ -6485,6 +6502,31 @@ - source sizes: - 32 +- name: diamond--outline + friendly_name: Diamond outline + aliases: + - diamond outlined + - outlined diamond + - stroke + - border + - diamond + - rectangle + - shape + - geometry + sizes: + - 32 +- name: diamond--solid + friendly_name: Diamond solid + aliases: + - diamond filled + - filled diamond + - solid + - diamond + - rectangle + - shape + - geometry + sizes: + - 32 - name: diamond-fill friendly_name: Diamond fill aliases: @@ -9395,6 +9437,56 @@ - help sizes: - 32 +- name: hexagon--outline + friendly_name: Hexagon outline + aliases: + - hexagon outlined + - outlined hexagon + - stroke + - border + - hexagon + - shape + - geometry + - horizontal + sizes: + - 32 +- name: hexagon--solid + friendly_name: Hexagon solid + aliases: + - hexagon filled + - filled hexagon + - solid + - hexagon + - shape + - geometry + - horizontal + sizes: + - 32 +- name: hexagon--vertical--outline + friendly_name: Hexagon vertical outline + aliases: + - hexagon outlined + - outlined hexagon + - stroke + - border + - hexagon + - shape + - geometry + - vertical + sizes: + - 32 +- name: hexagon--vertical--solid + friendly_name: Hexagon vertical solid + aliases: + - hexagon filled + - filled hexagon + - solid + - hexagon + - shape + - geometry + - vertical + sizes: + - 32 - name: hinton-plot friendly_name: Hinton plot aliases: @@ -15950,6 +16042,104 @@ - pending sizes: - 32 +- name: pentagon--down--outline + friendly_name: Pentagon down outline + aliases: + - pentagon outlined + - outlined pentagon + - stroke + - border + - pentagon + - shape + - geometry + - down + sizes: + - 32 +- name: pentagon--down--solid + friendly_name: Pentagon down solid + aliases: + - pentagon filled + - filled pentagon + - solid + - pentagon + - shape + - geometry + - down + sizes: + - 32 +- name: pentagon--left--outline + friendly_name: Pentagon left outline + aliases: + - pentagon outlined + - outlined pentagon + - stroke + - border + - pentagon + - shape + - geometry + - left + sizes: + - 32 +- name: pentagon--left--solid + friendly_name: Pentagon left solid + aliases: + - pentagon filled + - filled pentagon + - solid + - pentagon + - shape + - geometry + - left + sizes: + - 32 +- name: pentagon--outline + friendly_name: Pentagon outline + aliases: + - pentagon outlined + - outlined pentagon + - stroke + - border + - pentagon + - shape + - geometry + sizes: + - 32 +- name: pentagon--right--outline + friendly_name: Pentagon right outline + aliases: + - pentagon outlined + - outlined pentagon + - stroke + - border + - pentagon + - shape + - geometry + - right + sizes: + - 32 +- name: pentagon--right--solid + friendly_name: Pentagon right solid + aliases: + - pentagon filled + - filled pentagon + - solid + - pentagon + - shape + - geometry + - right + sizes: + - 32 +- name: pentagon--solid + friendly_name: Pentagon solid + aliases: + - pentagon filled + - filled pentagon + - solid + - pentagon + - shape + - geometry + sizes: + - 32 - name: percentage friendly_name: Percentage aliases: @@ -19190,6 +19380,31 @@ - query sizes: - 32 +- name: square--outline + friendly_name: Square outline + aliases: + - square outlined + - outlined square + - stroke + - border + - square + - rectangle + - shape + - geometry + sizes: + - 32 +- name: square--solid + friendly_name: Square solid + aliases: + - square filled + - filled square + - solid + - square + - rectangle + - shape + - geometry + sizes: + - 32 - name: square-fill friendly_name: Square fill aliases: @@ -21183,12 +21398,110 @@ - 32 - name: tree-view--alt friendly_name: Tree view alt - sizes: - - 32 aliases: - flow chart - data analytics - chart + sizes: + - 32 +- name: triangle--down--outline + friendly_name: Triangle down outline + aliases: + - triangle outlined + - outlined triangle + - stroke + - border + - triangle + - shape + - geometry + - down + sizes: + - 32 +- name: triangle--down--solid + friendly_name: Triangle down solid + aliases: + - triangle filled + - filled triangle + - solid + - triangle + - shape + - geometry + - down + sizes: + - 32 +- name: triangle--left--outline + friendly_name: Triangle left outline + aliases: + - triangle outlined + - outlined triangle + - stroke + - border + - triangle + - shape + - geometry + - left + sizes: + - 32 +- name: triangle--left--solid + friendly_name: Triangle left solid + aliases: + - triangle filled + - filled triangle + - solid + - triangle + - shape + - geometry + - left + sizes: + - 32 +- name: triangle--outline + friendly_name: Triangle outline + aliases: + - triangle outlined + - outlined triangle + - stroke + - border + - triangle + - shape + - geometry + sizes: + - 32 +- name: triangle--right--outline + friendly_name: Triangle right outline + aliases: + - triangle outlined + - outlined triangle + - stroke + - border + - triangle + - shape + - geometry + - right + sizes: + - 32 +- name: triangle--right--solid + friendly_name: Triangle right solid + aliases: + - triangle filled + - filled triangle + - solid + - triangle + - shape + - geometry + - right + sizes: + - 32 +- name: triangle--solid + friendly_name: Triangle solid + aliases: + - triangle filled + - filled triangle + - solid + - triangle + - shape + - geometry + sizes: + - 32 - name: trophy friendly_name: Trophy aliases: diff --git a/packages/icons/src/svg/32/circle--outline.svg b/packages/icons/src/svg/32/circle--outline.svg new file mode 100644 index 000000000000..573bc634a4f0 --- /dev/null +++ b/packages/icons/src/svg/32/circle--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/diamond--outline.svg b/packages/icons/src/svg/32/diamond--outline.svg new file mode 100644 index 000000000000..5318075618c6 --- /dev/null +++ b/packages/icons/src/svg/32/diamond--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/diamond--solid.svg b/packages/icons/src/svg/32/diamond--solid.svg new file mode 100644 index 000000000000..1ede7e2b7673 --- /dev/null +++ b/packages/icons/src/svg/32/diamond--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/hexagon--outline.svg b/packages/icons/src/svg/32/hexagon--outline.svg new file mode 100644 index 000000000000..d1339f54cdaa --- /dev/null +++ b/packages/icons/src/svg/32/hexagon--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/hexagon--solid.svg b/packages/icons/src/svg/32/hexagon--solid.svg new file mode 100644 index 000000000000..237bf41f5496 --- /dev/null +++ b/packages/icons/src/svg/32/hexagon--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/hexagon--vertical--outline.svg b/packages/icons/src/svg/32/hexagon--vertical--outline.svg new file mode 100644 index 000000000000..ac47a05a47cc --- /dev/null +++ b/packages/icons/src/svg/32/hexagon--vertical--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/hexagon--vertical--solid.svg b/packages/icons/src/svg/32/hexagon--vertical--solid.svg new file mode 100644 index 000000000000..1b68b3317d2f --- /dev/null +++ b/packages/icons/src/svg/32/hexagon--vertical--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/pentagon--down--outline.svg b/packages/icons/src/svg/32/pentagon--down--outline.svg new file mode 100644 index 000000000000..fc8effc0d89e --- /dev/null +++ b/packages/icons/src/svg/32/pentagon--down--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/pentagon--down--solid.svg b/packages/icons/src/svg/32/pentagon--down--solid.svg new file mode 100644 index 000000000000..4cc4f782195b --- /dev/null +++ b/packages/icons/src/svg/32/pentagon--down--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/pentagon--left--outline.svg b/packages/icons/src/svg/32/pentagon--left--outline.svg new file mode 100644 index 000000000000..580693132a5a --- /dev/null +++ b/packages/icons/src/svg/32/pentagon--left--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/pentagon--left--solid.svg b/packages/icons/src/svg/32/pentagon--left--solid.svg new file mode 100644 index 000000000000..5e24f8bc3648 --- /dev/null +++ b/packages/icons/src/svg/32/pentagon--left--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/pentagon--outline.svg b/packages/icons/src/svg/32/pentagon--outline.svg new file mode 100644 index 000000000000..38bb66122f10 --- /dev/null +++ b/packages/icons/src/svg/32/pentagon--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/pentagon--right--outline.svg b/packages/icons/src/svg/32/pentagon--right--outline.svg new file mode 100644 index 000000000000..0b1089e3e483 --- /dev/null +++ b/packages/icons/src/svg/32/pentagon--right--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/pentagon--right--solid.svg b/packages/icons/src/svg/32/pentagon--right--solid.svg new file mode 100644 index 000000000000..51454fab6fa2 --- /dev/null +++ b/packages/icons/src/svg/32/pentagon--right--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/pentagon--solid.svg b/packages/icons/src/svg/32/pentagon--solid.svg new file mode 100644 index 000000000000..1aab92518489 --- /dev/null +++ b/packages/icons/src/svg/32/pentagon--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/square--outline.svg b/packages/icons/src/svg/32/square--outline.svg new file mode 100644 index 000000000000..6c69683f1f65 --- /dev/null +++ b/packages/icons/src/svg/32/square--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/square--solid.svg b/packages/icons/src/svg/32/square--solid.svg new file mode 100644 index 000000000000..d82d270ded22 --- /dev/null +++ b/packages/icons/src/svg/32/square--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/triangle--down--outline.svg b/packages/icons/src/svg/32/triangle--down--outline.svg new file mode 100644 index 000000000000..aaaf60f79a40 --- /dev/null +++ b/packages/icons/src/svg/32/triangle--down--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/triangle--down--solid.svg b/packages/icons/src/svg/32/triangle--down--solid.svg new file mode 100644 index 000000000000..a74d76bceed6 --- /dev/null +++ b/packages/icons/src/svg/32/triangle--down--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/triangle--left--outline.svg b/packages/icons/src/svg/32/triangle--left--outline.svg new file mode 100644 index 000000000000..7a065b284170 --- /dev/null +++ b/packages/icons/src/svg/32/triangle--left--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/triangle--left--solid.svg b/packages/icons/src/svg/32/triangle--left--solid.svg new file mode 100644 index 000000000000..bbddb520c9c4 --- /dev/null +++ b/packages/icons/src/svg/32/triangle--left--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/triangle--outline.svg b/packages/icons/src/svg/32/triangle--outline.svg new file mode 100644 index 000000000000..4cb3e06e42d2 --- /dev/null +++ b/packages/icons/src/svg/32/triangle--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/triangle--right--outline.svg b/packages/icons/src/svg/32/triangle--right--outline.svg new file mode 100644 index 000000000000..ec802ada974c --- /dev/null +++ b/packages/icons/src/svg/32/triangle--right--outline.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/triangle--right--solid.svg b/packages/icons/src/svg/32/triangle--right--solid.svg new file mode 100644 index 000000000000..70085c7efe16 --- /dev/null +++ b/packages/icons/src/svg/32/triangle--right--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file diff --git a/packages/icons/src/svg/32/triangle--solid.svg b/packages/icons/src/svg/32/triangle--solid.svg new file mode 100644 index 000000000000..eeb5d653ddec --- /dev/null +++ b/packages/icons/src/svg/32/triangle--solid.svg @@ -0,0 +1,16 @@ + + + + + + + + \ No newline at end of file From f7ce9e068e53041b9f1b5d4de3186271852aaa08 Mon Sep 17 00:00:00 2001 From: TJ Egan Date: Mon, 15 Apr 2024 09:32:16 -0700 Subject: [PATCH 5/9] feat(Tile): update Tile AI styles to phase 3 spec (#16183) * feat(Tile): update Tile AI styles to phase 3 spec * fix(Tile): adjust callout gradient --- packages/styles/scss/components/tile/_tile.scss | 15 ++++++++++++--- packages/styles/scss/utilities/_ai-gradient.scss | 2 ++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/packages/styles/scss/components/tile/_tile.scss b/packages/styles/scss/components/tile/_tile.scss index 449e67c002df..f20bc70833d6 100644 --- a/packages/styles/scss/components/tile/_tile.scss +++ b/packages/styles/scss/components/tile/_tile.scss @@ -85,6 +85,8 @@ $-icon-container-size: calc(#{layout.density('padding-inline')} * 2 + 1rem); &:focus { @include focus-outline('outline'); + + text-decoration: none; } &:hover, @@ -398,7 +400,7 @@ $-icon-container-size: calc(#{layout.density('padding-inline')} * 2 + 1rem); border: 1px solid transparent; box-shadow: inset 0 -80px 70px -65px $ai-inner-shadow, - 0 24px 40px -24px $ai-drop-shadow; + 0 4px 8px 0 $ai-drop-shadow; } .#{$prefix}--tile--slug.#{$prefix}--tile--expandable:hover { @@ -423,7 +425,8 @@ $-icon-container-size: calc(#{layout.density('padding-inline')} * 2 + 1rem); .#{$prefix}--tile--slug.#{$prefix}--tile--clickable::before { @include ai-popover-gradient('hover', 0, 'layer'); - box-shadow: inset 0 -80px 70px -65px $ai-inner-shadow; + box-shadow: inset 0 -80px 70px -65px $ai-inner-shadow, + 0 4px 10px 2px $ai-drop-shadow; } .#{$prefix}--tile--slug.#{$prefix}--tile--selectable:hover::before, @@ -431,10 +434,16 @@ $-icon-container-size: calc(#{layout.density('padding-inline')} * 2 + 1rem); opacity: 1; } + .#{$prefix}--tile--slug.#{$prefix}--tile--selectable:focus, + .#{$prefix}--tile--slug.#{$prefix}--tile--clickable:focus { + outline-offset: -1px; + } + .#{$prefix}--tile--slug.#{$prefix}--tile--selectable::after { @include ai-popover-gradient('selected', 0, 'layer'); - box-shadow: inset 0 -80px 70px -65px $ai-inner-shadow; + box-shadow: inset 0 -80px 70px -65px $ai-inner-shadow, + 0 4px 8px 0 $ai-drop-shadow; } .#{$prefix}--tile--slug.#{$prefix}--tile--selectable:hover::after { diff --git a/packages/styles/scss/utilities/_ai-gradient.scss b/packages/styles/scss/utilities/_ai-gradient.scss index ccd271f5457b..6199d03df344 100644 --- a/packages/styles/scss/utilities/_ai-gradient.scss +++ b/packages/styles/scss/utilities/_ai-gradient.scss @@ -115,6 +115,7 @@ background: linear-gradient( to top, theme.$ai-aura-start $start, + 15%, theme.$ai-aura-end 50% ) padding-box, @@ -129,6 +130,7 @@ to top, $background $start, theme.$ai-aura-start $start, + 15%, theme.$ai-aura-end 50% ) padding-box, From ddb5f2ad4db28a130bae34a58d0249fe2a465df2 Mon Sep 17 00:00:00 2001 From: Guilherme Datilio Ribeiro Date: Mon, 15 Apr 2024 13:32:48 -0300 Subject: [PATCH 6/9] fix: fixed coverage on typescript files (#16192) --- jest.config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/jest.config.js b/jest.config.js index eb989026c2f1..b174a0d72729 100644 --- a/jest.config.js +++ b/jest.config.js @@ -11,6 +11,7 @@ module.exports = { preset: 'jest-config-carbon', collectCoverageFrom: [ 'packages/**/src/**/*.js', + 'packages/**/src/**/*.tsx', '!packages/{cli,components}/**', '!packages/**/{examples,stories}/**', '!**/*-story.js', From df51fc5d382850e5a466b3eff6650f0287153095 Mon Sep 17 00:00:00 2001 From: Gururaj J <89023023+Gururajj77@users.noreply.github.com> Date: Mon, 15 Apr 2024 22:03:59 +0530 Subject: [PATCH 7/9] fix(headermenu): headermenu typing corrected (#16191) Co-authored-by: Taylor Jones --- packages/react/src/components/UIShell/HeaderMenu.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/UIShell/HeaderMenu.tsx b/packages/react/src/components/UIShell/HeaderMenu.tsx index 7944554674ce..3fbe2c5bd307 100644 --- a/packages/react/src/components/UIShell/HeaderMenu.tsx +++ b/packages/react/src/components/UIShell/HeaderMenu.tsx @@ -375,8 +375,8 @@ class HeaderMenu extends React.Component { }; } -const HeaderMenuForwardRef = React.forwardRef((props, ref) => { - return ; +const HeaderMenuForwardRef = React.forwardRef((props: HeaderMenuProps, ref) => { + return ; }); HeaderMenuForwardRef.displayName = 'HeaderMenu'; From 046ae78973e09cc984ecb51499ee16d17f6811f1 Mon Sep 17 00:00:00 2001 From: Nikhil Tomar <63502271+2nikhiltom@users.noreply.github.com> Date: Tue, 16 Apr 2024 01:21:41 +0530 Subject: [PATCH 8/9] fix(16059): updates RadioButton and RadioButtonGroup proptypes (#16186) * fix(16059): updated props for RadioButton, RadioButtonGroup * fix(16059): selection type of RadioButtonGroup * fix(16059): type updated for onChange --- packages/react/src/components/RadioButton/RadioButton.tsx | 2 +- .../src/components/RadioButtonGroup/RadioButtonGroup.tsx | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/react/src/components/RadioButton/RadioButton.tsx b/packages/react/src/components/RadioButton/RadioButton.tsx index 0b8a1f2b7f2b..36367070d49b 100644 --- a/packages/react/src/components/RadioButton/RadioButton.tsx +++ b/packages/react/src/components/RadioButton/RadioButton.tsx @@ -74,7 +74,7 @@ export interface RadioButtonProps onChange?: ( value: string | number, name: string | undefined, - event: any + event: React.ChangeEvent ) => void; /** diff --git a/packages/react/src/components/RadioButtonGroup/RadioButtonGroup.tsx b/packages/react/src/components/RadioButtonGroup/RadioButtonGroup.tsx index 7cdc2ae72bb2..f3a982c471a5 100644 --- a/packages/react/src/components/RadioButtonGroup/RadioButtonGroup.tsx +++ b/packages/react/src/components/RadioButtonGroup/RadioButtonGroup.tsx @@ -80,8 +80,11 @@ export interface RadioButtonGroupProps * Provide an optional `onChange` hook that is called whenever the value of * the group changes */ - onChange?: (selection: unknown, name: string, evt: unknown) => void; - + onChange?: ( + selection: React.ReactNode, + name: string, + event: React.ChangeEvent + ) => void; /** * Provide where radio buttons should be placed */ From 0326f87ff86c539b186d49b3de8e2b270beca310 Mon Sep 17 00:00:00 2001 From: Jawahar S Date: Tue, 16 Apr 2024 01:41:33 +0530 Subject: [PATCH 9/9] SelectableTile change event returns current state, name (#16112) * SelectableTile change event returns current state, name https://github.com/carbon-design-system/carbon/issues/11052 * keeping event argument in the same position Co-authored-by: Taylor Jones * feat: name is depreciated so passing id * chore: contributors list updated --------- Co-authored-by: Taylor Jones --- .all-contributorsrc | 9 +++++++++ README.md | 1 + packages/react/src/components/Tile/Tile.tsx | 12 ++++++++---- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index cb4fe6340ebe..9284fb4ee712 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1470,6 +1470,15 @@ "contributions": [ "code" ] + }, + { + "login": "Jawahars", + "name": "Jawahar S", + "avatar_url": "https://avatars.githubusercontent.com/u/4353146?v=4", + "profile": "https://github.com/Jawahars", + "contributions": [ + "code" + ] } ], "commitConvention": "none" diff --git a/README.md b/README.md index e2aa6524ef13..c3ee76495ed7 100644 --- a/README.md +++ b/README.md @@ -282,6 +282,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
Anjana M R
💻
Joseph Schultz
💻
anjaly0606
💻 +
Jawahar S
💻 diff --git a/packages/react/src/components/Tile/Tile.tsx b/packages/react/src/components/Tile/Tile.tsx index 89c4e4b02b8d..a37dd24c544d 100644 --- a/packages/react/src/components/Tile/Tile.tsx +++ b/packages/react/src/components/Tile/Tile.tsx @@ -372,7 +372,11 @@ export interface SelectableTileProps extends HTMLAttributes { /** * The empty handler of the ``. */ - onChange?(event: ChangeEvent): void; + onChange?( + event: ChangeEvent, + selected?: boolean, + id?: string + ): void; /** * Specify the function to run when the SelectableTile is clicked @@ -463,7 +467,7 @@ export const SelectableTile = React.forwardRef< } setIsSelected(!isSelected); clickHandler(evt); - onChange(evt); + onChange(evt, isSelected, id); } // TODO: rename to handleKeyDown when handleKeyDown prop is deprecated @@ -472,14 +476,14 @@ export const SelectableTile = React.forwardRef< if (matches(evt, [keys.Enter, keys.Space])) { evt.preventDefault(); setIsSelected(!isSelected); - onChange(evt); + onChange(evt, isSelected, id); } keyDownHandler(evt); } function handleChange(event) { setIsSelected(event.target.checked); - onChange(event); + onChange(event, isSelected, id); } if (selected !== prevSelected) {