From e626cdf1d95bfc0b20455d1ad28edd68048b5c83 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Fri, 13 Dec 2019 13:47:54 -0600 Subject: [PATCH 1/3] fix(button): update focus styles to use box-shadow (#4867) --- packages/components/src/components/button/_mixins.scss | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/components/src/components/button/_mixins.scss b/packages/components/src/components/button/_mixins.scss index 42741257e0f5..020f645206cc 100644 --- a/packages/components/src/components/button/_mixins.scss +++ b/packages/components/src/components/button/_mixins.scss @@ -26,8 +26,7 @@ text-align: left; text-decoration: none; transition: all $duration--fast-01 motion(entrance, productive); - outline: $button-outline-width solid transparent; - outline-offset: -4px; + outline: none; position: relative; max-width: rem(320px); @@ -72,7 +71,7 @@ &:focus { border-color: $focus; - outline-color: $ui-02; + box-shadow: inset 0 0 0 $button-outline-width $ui-02; } &:disabled:hover, @@ -83,7 +82,7 @@ background-color: $disabled-02; border-color: $disabled-02; text-decoration: none; - outline-color: $disabled-02; + box-shadow: none; } &:active { From b84d02778875fd3656aed7779171c26bed1f90e1 Mon Sep 17 00:00:00 2001 From: carbon-bot Date: Fri, 13 Dec 2019 19:59:02 +0000 Subject: [PATCH 2/3] chore(project): sync generated files --- packages/components/docs/sass.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/components/docs/sass.md b/packages/components/docs/sass.md index 69eec14e8f66..5ae459688efa 100644 --- a/packages/components/docs/sass.md +++ b/packages/components/docs/sass.md @@ -13082,8 +13082,7 @@ Button base styles text-align: left; text-decoration: none; transition: all $duration--fast-01 motion(entrance, productive); - outline: $button-outline-width solid transparent; - outline-offset: -4px; + outline: none; position: relative; max-width: rem(320px); @@ -13136,7 +13135,7 @@ Button variant styles &:focus { border-color: $focus; - outline-color: $ui-02; + box-shadow: inset 0 0 0 $button-outline-width $ui-02; } &:disabled:hover, @@ -13147,7 +13146,7 @@ Button variant styles background-color: $disabled-02; border-color: $disabled-02; text-decoration: none; - outline-color: $disabled-02; + box-shadow: none; } &:active { From d364e9ac629fd06916223b153f715bf9621a1417 Mon Sep 17 00:00:00 2001 From: Matt Rosno Date: Fri, 13 Dec 2019 16:26:29 -0600 Subject: [PATCH 3/3] Update stalebot with new labels (#4878) --- .github/stale.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/stale.yml b/.github/stale.yml index dd37353fbf9f..2cb67e4cc112 100644 --- a/.github/stale.yml +++ b/.github/stale.yml @@ -6,11 +6,11 @@ daysUntilClose: 3 exemptLabels: - 'type: a11y ♿' - 'type: bug 🐛' - - 'Severity 1 🚨' - - 'priority: high' - - 'v11' + - 'severity: 1 🚨' + - 'impact: 1' + - 'version: 11' # Label to use when marking an issue as stale -staleLabel: inactive +staleLabel: 'status: inactive' # Comment to post when marking an issue as stale. Set to `false` to disable markComment: > We've marked this issue as stale because there hasn't been any activity for a couple of weeks.