-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Link] Add inline link variant #1465
Comments
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions. |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
I see this a ton in product and would still like to see it as a component. Right now, links aren't accessible inline |
@eraymond25 Would you be interested in elaborating what the link your proposed is, probably from design perspective, so we can see if there is a @carbon-design-system/design's interest? Thanks! |
@asudoh for sure! It's not a big difference, just underlined when enabled so that it's visually different from the text around it Stand alone links don't need this underline though, so 2 types would be great! |
Yeah agreed. I think we need both options. |
We have 2 additional components designed previously: Secondary link, and Inline link. Does this spec for Inline link look good for your usage @eraymond25 ? Adding these components will be enhancement work and we can add them to the queue of to-dos. |
Yes, exactly @shixiedesign! thanks 👍 Secondary links should probably be in that queue as well |
just to clarify, does "inline link" only mean that the link must have the underline decoration by default? and is the default color the only difference between secondary and primary links? |
Yep @emyarod that's correct! |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
note stale |
this depends on the possible changes to Link hover/focus/active spec right? |
Yep... #3059 |
This issue needs new spec. To clean up the thread, I will close and open an new one, see: #3228 |
Summary
Currently the experimental link component looks to be only for a stand-alone link. We may need to develop a second version of link that is for inline, per accessibility and color can't be the only thing differentiating an inline link. Design + Dev
Justification
If in experimental you're only mimicking Carbon current functionality, then you'll need two version because of the new styling: in-line and stand alone. The current Carbon link seems to be for both situations.
Desired UX and success metrics
Similar to how link works today.
"Must have" functionality
Will we be able to have a link with an icon? This is pretty highly used in Marketing. If it's not on your timeline we will need to contribute.
Specific timeline issues / requests
Before Carbon X release
Available extra resources
Digital team to help Design!
The text was updated successfully, but these errors were encountered: