Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Link] Add inline link variant #1465

Closed
eraymond25 opened this issue Nov 21, 2018 · 15 comments
Closed

[Link] Add inline link variant #1465

eraymond25 opened this issue Nov 21, 2018 · 15 comments

Comments

@eraymond25
Copy link

Summary

Currently the experimental link component looks to be only for a stand-alone link. We may need to develop a second version of link that is for inline, per accessibility and color can't be the only thing differentiating an inline link. Design + Dev

Justification

If in experimental you're only mimicking Carbon current functionality, then you'll need two version because of the new styling: in-line and stand alone. The current Carbon link seems to be for both situations.

Desired UX and success metrics

Similar to how link works today.

"Must have" functionality

Will we be able to have a link with an icon? This is pretty highly used in Marketing. If it's not on your timeline we will need to contribute.

Specific timeline issues / requests

Before Carbon X release

Available extra resources

Digital team to help Design!

@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@stale stale bot added the wontfix label May 1, 2019
@dakahn dakahn removed the wontfix label May 6, 2019
@stale
Copy link

stale bot commented May 20, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label May 20, 2019
@eraymond25
Copy link
Author

I see this a ton in product and would still like to see it as a component. Right now, links aren't accessible inline

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label May 21, 2019
@asudoh
Copy link
Contributor

asudoh commented May 22, 2019

@eraymond25 Would you be interested in elaborating what the link your proposed is, probably from design perspective, so we can see if there is a @carbon-design-system/design's interest? Thanks!

@eraymond25
Copy link
Author

@asudoh for sure! It's not a big difference, just underlined when enabled so that it's visually different from the text around it

Stand alone links don't need this underline though, so 2 types would be great!

@aagonzales
Copy link
Member

Yeah agreed. I think we need both options.

@shixiedesign
Copy link
Contributor

shixiedesign commented May 22, 2019

We have 2 additional components designed previously: Secondary link, and Inline link. Does this spec for Inline link look good for your usage @eraymond25 ? Adding these components will be enhancement work and we can add them to the queue of to-dos.

Link white

@eraymond25
Copy link
Author

Yes, exactly @shixiedesign! thanks 👍

Secondary links should probably be in that queue as well

@shixiedesign shixiedesign changed the title Experimental Component: inline link [Link] Add inline link variant May 23, 2019
@emyarod emyarod self-assigned this May 28, 2019
@emyarod
Copy link
Member

emyarod commented May 28, 2019

just to clarify, does "inline link" only mean that the link must have the underline decoration by default? and is the default color the only difference between secondary and primary links?

@shixiedesign
Copy link
Contributor

Yep @emyarod that's correct!

@stale
Copy link

stale bot commented Jun 27, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 27, 2019
@shixiedesign
Copy link
Contributor

note stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Jun 27, 2019
@emyarod
Copy link
Member

emyarod commented Jun 27, 2019

this depends on the possible changes to Link hover/focus/active spec right?

@shixiedesign
Copy link
Contributor

Yep... #3059

@shixiedesign
Copy link
Contributor

This issue needs new spec. To clean up the thread, I will close and open an new one, see: #3228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants