Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toggle] change toggle content for headings and labels #15240

Closed
1 task done
laurenmrice opened this issue Nov 22, 2023 · 4 comments · Fixed by #17315
Closed
1 task done

[Toggle] change toggle content for headings and labels #15240

laurenmrice opened this issue Nov 22, 2023 · 4 comments · Fixed by #17315

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Nov 22, 2023

Acceptance criteria

  • As part of an a11y review, we should change the terminology for how we label parts of the Toggle component in the storybook example.
    • The Toggles label above the toggle should be called Label not Toggle element label.
Frame 1872

Code of Conduct

Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@tay1orjones
Copy link
Member

This is just a storybook change. The code is right, just the words in storybook are wrong.

@mbgower
Copy link

mbgower commented Feb 26, 2024

I think the best way to get clarity on this is to have an anatomy section for the toggle.
There is (as far as I know) no real heading, although I guess a set of toggles could have a heading. What is called a heading here is actually the toggle's label. The label and the toggle control are sometimes aligned in rows, I believe.
What is called a label above is actually a text-version of the toggle's state (on or off).

@alisonjoseph alisonjoseph added this to the 2024 Q2 milestone Mar 21, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q2, 2024 Q3 Jul 2, 2024
@mbgower
Copy link

mbgower commented Aug 26, 2024

I agree this can be changed by some documentation changes (on the website --and probably on Figma?) and updates to storybook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

6 participants