test: added unit tests for SwitcherItem component to improve coverage #17876
+97
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17876 +/- ##
==========================================
+ Coverage 81.84% 81.92% +0.08%
==========================================
Files 404 404
Lines 14095 14095
Branches 4413 4364 -49
==========================================
+ Hits 11536 11548 +12
+ Misses 2397 2385 -12
Partials 162 162 ☔ View full report in Codecov by Sentry. |
|
Hi @kennylam , can you please review this? |
kennylam
approved these changes
Nov 12, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 12, 2024
4e5ffb2
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17494
This PR adds unit tests for the SwitcherItem component to increase its coverage by ensuring its proper rendering and functionality. The tests verify that the skeleton displays with the correct classes, supports custom class names etc.
Changelog
Changed
Testing / Reviewing
Additional Notes