Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fileuploader component: Multiple prop set to false but all selected files are accepted. #2537

Closed
kalyanixraut opened this issue Feb 12, 2019 · 6 comments · Fixed by #5492
Closed
Assignees
Labels
component: file-uploader package: react carbon-components-react role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 version: 9 Issues pertaining to legacy Carbon

Comments

@kalyanixraut
Copy link

Fileuploader component: Multiple prop set to false but all selected files are accepted.

Detailed description

Hello Team,
We are using Fileuploader component, even though multiple prop is set to false one can select files one by one and all selected files are accepted.

Steps to reproduce the issue

http://react.carbondesignsystem.com/?selectedKind=FileUploader&selectedStory=FileUploader&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs

Additional information

image

@emyarod
Copy link
Member

emyarod commented Feb 12, 2019

hi @kalyanixraut thanks for reporting this! this issue was originally addressed in carbon-design-system/carbon-components-react#1105 but since that PR was shelved for a bit I may push a fix for this

this may be considered a breaking change though, so it may be delayed until #1105 can be reopened again

@emyarod emyarod self-assigned this Feb 12, 2019
@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@carbon-bot carbon-bot added package: react carbon-components-react priority: high type: bug 🐛 version: 9 Issues pertaining to legacy Carbon labels May 9, 2019
@carbon-bot
Copy link
Contributor

Hi there! 👋 If you're wondering why this issue was moved, we're currently updating our repo structure so that every package is found in the same project.

This should not have any impact for you, but we wanted to give you a heads up in case you were wondering what is going on. If you have any questions, feel free to reach out to us on Slack or contact us at: [email protected]. Thanks!

@PAnilReddy
Copy link

@emyarod , We are also facing the same problem. Can we know when the fix can come.
Also can you give me the slack channel for this repo.

@emyarod
Copy link
Member

emyarod commented Jun 26, 2019

this should be addressed in #3175, and we may look into backporting the fix for the legacy file uploader

@elhagin
Copy link

elhagin commented Dec 4, 2019

hi, are there any updates on this issue? the same thing is occurring to me and I can't find any solution. I see that it should be fixed in FileUploaderV2 but I'm not sure if that has been merged or not.

TIA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: file-uploader package: react carbon-components-react role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 version: 9 Issues pertaining to legacy Carbon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants