Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The react carbon component ToggleSmall doesn't have labels #2856

Closed
2 tasks done
xpander53 opened this issue May 28, 2019 · 2 comments
Closed
2 tasks done

The react carbon component ToggleSmall doesn't have labels #2856

xpander53 opened this issue May 28, 2019 · 2 comments
Assignees

Comments

@xpander53
Copy link

xpander53 commented May 28, 2019

What package(s) are you using?

"carbon-components": "^10.2.0",
"carbon-components-react": "^6.114.1",

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

The react carbon component ToggleSmall doesn't have labels like the design.
https://www.carbondesignsystem.com/components/toggle/code

Is this issue related to a specific component?
Yes ToggleSmall

What did you expect to happen? What happened instead? What would you like to
see changed?

The ToggleSmall should have the option to have on/off labels like the design. I can use Toggle and get the labels but it doesn't look exactly like ToggleSmall. Or I can use ToggleSmall but I would have to create and change my own labels.

What browser are you working in?
Chrome

What version of the Carbon Design System are you using?
v10

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Watson Health for Clinical Trial Matching

Steps to reproduce the issue

No steps - you can see the react implementation doesn't follow the design.
http://react.carbondesignsystem.com/?selectedKind=ToggleSmall&selectedStory=toggled&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs

Please create a reduced test case in CodeSandbox
https://codesandbox.io/s/github/IBM/carbon-components/tree/master/examples/codesandbox

Additional information

You can reach me on Slack -- [email protected] / Joel Maner

  • Screenshots or code
  • Notes
@dakahn dakahn added priority: high severity: 3 https://ibm.biz/carbon-severity labels May 28, 2019
@snidersd
Copy link

@dakahn Also see issue #2809 which is related to toggle labels. In addition, please add the A11y label and include it in the IBM Carbon Copy milestone. Thx!

@dakahn dakahn added this to the IBMa Carbon Copy 🧁 milestone May 30, 2019
@dakahn dakahn assigned dakahn and emyarod and unassigned dakahn Jun 13, 2019
@abbeyhrt
Copy link
Contributor

This issue was solved through PR #2885 🎉

@dakahn dakahn modified the milestones: IBMa Carbon Copy, ♿Carbon WCAG Compliance♿ Nov 21, 2019
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants