Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] review behaviors and guidance #2935

Closed
shixiedesign opened this issue Jun 5, 2019 · 12 comments
Closed

[Modal] review behaviors and guidance #2935

shixiedesign opened this issue Jun 5, 2019 · 12 comments
Labels
package: components carbon-components status: inactive Will close if there's no further activity within a given time type: enhancement 💡

Comments

@shixiedesign
Copy link
Contributor

Need to review and fix a behaviors of modals overall across the 3 variants we have:

transactional probably shouldn't have the "click anywhere to close" function

Originally posted by @aagonzales in carbon-design-system/carbon-website#1696

@elizabethsjudd
Copy link
Contributor

@shixiedesign @aagonzales There is a coordination between Carbon, IBMa, and WH right now is working on how some of the behaviors and guidance is documented. WH is actually currently working on the Modal component right now. I'd really like to get more people involved in this effort, so if you want, I can set up some time with you to go over what we have.

@elizabethsjudd
Copy link
Contributor

Specifically we have a variant that is similar to what @aagonzales is proposing in the main issue comment quote called Required Action that we are hoping to contribute. I have a meeting with our designer today to see where we are at on the design side for this variant specifically.

@shixiedesign
Copy link
Contributor Author

@elizabethsjudd 100% support the idea! We are happy to review any content you've got and we can align / combine. Feel free to set a time up when you are ready to share. We've got a couple components (eg. notification) that need guidance review, but no resources to tackle them this month.

@aagonzales
Copy link
Member

Related: #2922

@shixiedesign
Copy link
Contributor Author

Pass a prop to prevent modal from closing when clicking outside modal.

@stale
Copy link

stale bot commented Jul 26, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jul 26, 2019
@shixiedesign
Copy link
Contributor Author

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Jul 29, 2019
@stale
Copy link

stale bot commented Aug 28, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 28, 2019
@elizabethsjudd
Copy link
Contributor

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Aug 28, 2019
@stale
Copy link

stale bot commented Sep 27, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Sep 27, 2019
@stale
Copy link

stale bot commented Sep 30, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Sep 30, 2019
@elizabethsjudd
Copy link
Contributor

not stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: components carbon-components status: inactive Will close if there's no further activity within a given time type: enhancement 💡
Projects
None yet
Development

No branches or pull requests

3 participants